Bug 92529

Summary: Change constructor with explicit constructor in WebCore/Modules
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-07-27 12:08:52 PDT
As a step to let *explicit* keyword add to constructors which have a parameter, *explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit type conversion.
Attachments
Patch (22.87 KB, patch)
2012-07-27 12:11 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-27 12:11:55 PDT
Created attachment 155013 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-27 12:12:42 PDT
This patch should pass all ews.
Chris Dumez
Comment 3 2012-07-27 12:17:51 PDT
Comment on attachment 155013 [details] Patch LGTM.
Kentaro Hara
Comment 4 2012-07-27 17:33:10 PDT
Comment on attachment 155013 [details] Patch Looks OK. Please land the patch when you can keep watching the tree so that we can roll it out if it breaks any build.
Gyuyoung Kim
Comment 5 2012-07-27 17:34:38 PDT
Sure, when win ews is passed, I will land this. Then, I start to watch buildbot trees. Thanks.
WebKit Review Bot
Comment 6 2012-07-27 18:24:14 PDT
Comment on attachment 155013 [details] Patch Clearing flags on attachment: 155013 Committed r123945: <http://trac.webkit.org/changeset/123945>
WebKit Review Bot
Comment 7 2012-07-27 18:24:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.