Bug 92526

Summary: Increase inline storage for JSFinalObjects by one
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Severity: Normal CC: fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
ggaren: review+
Benchmark results none

Description Mark Hahnenberg 2012-07-27 11:54:31 PDT
Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on 64-bit platforms by 1.
Comment 1 Mark Hahnenberg 2012-07-27 11:56:16 PDT
Created attachment 155005 [details]
Comment 2 Mark Hahnenberg 2012-07-27 11:58:54 PDT
Created attachment 155006 [details]
Benchmark results

Looks like a slight win on v8-real (~7% on richards) and kraken (~2% on imaging-darkroom).
Comment 3 Geoffrey Garen 2012-07-27 12:12:52 PDT
Comment on attachment 155005 [details]


This is going to make our lives harder when we go back to shrink these objects later, since it will be harder to do so without causing a performance regression. :( I guess we'll need to fast-track being smart about predicting and/or responding to object size.
Comment 4 Mark Hahnenberg 2012-07-27 12:29:19 PDT
Committed r123905: <http://trac.webkit.org/changeset/123905>