Bug 92526

Summary: Increase inline storage for JSFinalObjects by one
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Benchmark results none

Mark Hahnenberg
Reported 2012-07-27 11:54:31 PDT
Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on 64-bit platforms by 1.
Attachments
Patch (1.76 KB, patch)
2012-07-27 11:56 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Benchmark results (18.88 KB, text/plain)
2012-07-27 11:58 PDT, Mark Hahnenberg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-07-27 11:56:16 PDT
Created attachment 155005 [details] Patch
Mark Hahnenberg
Comment 2 2012-07-27 11:58:54 PDT
Created attachment 155006 [details] Benchmark results Looks like a slight win on v8-real (~7% on richards) and kraken (~2% on imaging-darkroom).
Geoffrey Garen
Comment 3 2012-07-27 12:12:52 PDT
Comment on attachment 155005 [details] Patch r=me This is going to make our lives harder when we go back to shrink these objects later, since it will be harder to do so without causing a performance regression. :( I guess we'll need to fast-track being smart about predicting and/or responding to object size.
Mark Hahnenberg
Comment 4 2012-07-27 12:29:19 PDT
Committed r123905: <http://trac.webkit.org/changeset/123905>
Note You need to log in before you can comment on or make changes to this bug.