Summary: | Increase inline storage for JSFinalObjects by one | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fpizlo, ggaren | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Hahnenberg
2012-07-27 11:54:31 PDT
Created attachment 155005 [details]
Patch
Created attachment 155006 [details]
Benchmark results
Looks like a slight win on v8-real (~7% on richards) and kraken (~2% on imaging-darkroom).
Comment on attachment 155005 [details]
Patch
r=me
This is going to make our lives harder when we go back to shrink these objects later, since it will be harder to do so without causing a performance regression. :( I guess we'll need to fast-track being smart about predicting and/or responding to object size.
Committed r123905: <http://trac.webkit.org/changeset/123905> |