Bug 92525

Summary: [Chromium] Enable deferred canvas rendering with SkGPipe in DumpRenderTree
Product: WebKit Reporter: Justin Novosad <junov>
Component: New BugsAssignee: Justin Novosad <junov>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, kbr, reed, schenney, scroggo, senorblanco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-08
none
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Archive of layout-test-results from gce-cr-linux-05 none

Justin Novosad
Reported 2012-07-27 11:40:41 PDT
[Chromium] Enable deferred canvas rendering with SkGPipe in DumpRenderTree
Attachments
Patch (8.35 KB, patch)
2012-07-27 11:50 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (999.24 KB, application/zip)
2012-07-27 15:54 PDT, WebKit Review Bot 		no flags
Details
Patch (4.89 KB, patch)
2012-08-01 13:20 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (538.27 KB, application/zip)
2012-08-01 14:47 PDT, WebKit Review Bot 		no flags
Details
Archive of layout-test-results from gce-cr-linux-05 (573.39 KB, application/zip)
2012-08-01 15:48 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Novosad
Comment 1 2012-07-27 11:50:17 PDT
Created attachment 155003 [details] Patch
Mike Reed
Comment 2 2012-07-27 11:55:32 PDT
I isn't no reviewer, but seems right to me.
Justin Novosad
Comment 3 2012-07-27 14:06:14 PDT
Putting this change on hold because the test expectation are in flux. skia r4817 addresses 15 of the 18 fails. I will wait for the next skia roll to come in and resubmit a patch with fresh expectations.
Kenneth Russell
Comment 4 2012-07-27 14:11:21 PDT
Comment on attachment 155003 [details] Patch Patch looks fine modulo the coming test expectations updates. r=me
WebKit Review Bot
Comment 5 2012-07-27 15:54:02 PDT
Comment on attachment 155003 [details] Patch Attachment 155003 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13368814 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline.html
WebKit Review Bot
Comment 6 2012-07-27 15:54:07 PDT
Created attachment 155077 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Justin Novosad
Comment 7 2012-08-01 13:20:27 PDT
Created attachment 155870 [details] Patch
Stephen White
Comment 8 2012-08-01 13:23:02 PDT
Comment on attachment 155870 [details] Patch Looks good, bots willing. r=me
WebKit Review Bot
Comment 9 2012-08-01 14:47:10 PDT
Comment on attachment 155870 [details] Patch Attachment 155870 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13404570 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-composite.html platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas.html platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip.html
WebKit Review Bot
Comment 10 2012-08-01 14:47:13 PDT
Created attachment 155890 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
WebKit Review Bot
Comment 11 2012-08-01 15:48:30 PDT
Comment on attachment 155870 [details] Patch Attachment 155870 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13418313 New failing tests: platform/chromium/virtual/gpu/fast/canvas/canvas-composite.html platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas.html platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip.html
WebKit Review Bot
Comment 12 2012-08-01 15:48:34 PDT
Created attachment 155907 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Note You need to log in before you can comment on or make changes to this bug.