Summary: | [BlackBerry] Optimize the generation of selection details generation. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||
Component: | WebKit BlackBerry | Assignee: | Mike Fenton <mifenton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mike Fenton
2012-07-27 11:25:09 PDT
Created attachment 154993 [details]
Patch
Attachment 154993 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:257: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 154993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154993&action=review > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:246 > + selectionPositionChanged(true /* forceUpdateWithoutChange */); Update of? Change what? :) Created attachment 155009 [details]
Updated Patch
Comment on attachment 154993 [details] Patch Cleared Antonio Gomes's review+ from obsolete attachment 154993 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 155009 [details] Updated Patch Rejecting attachment 155009 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13367819 Comment on attachment 155009 [details] Updated Patch Clearing flags on attachment: 155009 Committed r124050: <http://trac.webkit.org/changeset/124050> All reviewed patches have been landed. Closing bug. |