RESOLVED FIXED 92522
[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522
Summary [BlackBerry] Optimize the generation of selection details generation.
Mike Fenton
Reported 2012-07-27 11:25:09 PDT
Reduce the calls avoiding duplicate notifications.
Attachments
Patch (11.23 KB, patch)
2012-07-27 11:27 PDT, Mike Fenton
no flags
Updated Patch (11.23 KB, patch)
2012-07-27 12:05 PDT, Mike Fenton
no flags
Mike Fenton
Comment 1 2012-07-27 11:27:29 PDT
WebKit Review Bot
Comment 2 2012-07-27 11:30:36 PDT
Attachment 154993 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:257: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antonio Gomes
Comment 3 2012-07-27 11:57:40 PDT
Comment on attachment 154993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154993&action=review > Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:246 > + selectionPositionChanged(true /* forceUpdateWithoutChange */); Update of? Change what? :)
Mike Fenton
Comment 4 2012-07-27 12:05:57 PDT
Created attachment 155009 [details] Updated Patch
Eric Seidel (no email)
Comment 5 2012-07-27 12:12:16 PDT
Comment on attachment 154993 [details] Patch Cleared Antonio Gomes's review+ from obsolete attachment 154993 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Review Bot
Comment 6 2012-07-27 13:58:09 PDT
Comment on attachment 155009 [details] Updated Patch Rejecting attachment 155009 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13367819
WebKit Review Bot
Comment 7 2012-07-30 10:48:51 PDT
Comment on attachment 155009 [details] Updated Patch Clearing flags on attachment: 155009 Committed r124050: <http://trac.webkit.org/changeset/124050>
WebKit Review Bot
Comment 8 2012-07-30 10:48:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.