Bug 92510

Summary: [BlackBerry] Should support onbeforeunload event and show confirmation dialog
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
change the name
none
updated none

Yong Li
Reported 2012-07-27 08:52:57 PDT
Should support onbeforeunload event and show confirmation dialog
Attachments
the patch (4.03 KB, patch)
2012-07-27 08:59 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
change the name (4.10 KB, patch)
2012-07-27 10:02 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
updated (4.20 KB, patch)
2012-07-27 10:09 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-07-27 08:59:15 PDT
Created attachment 154966 [details] the patch
Antonio Gomes
Comment 2 2012-07-27 09:47:16 PDT
Comment on attachment 154966 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=154966&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:997 > +bool WebPage::shouldClose() this is not a good name, imo.
Yong Li
Comment 3 2012-07-27 10:02:16 PDT
Created attachment 154979 [details] change the name
Yong Li
Comment 4 2012-07-27 10:09:30 PDT
Created attachment 154980 [details] updated
WebKit Review Bot
Comment 5 2012-07-27 11:13:18 PDT
Comment on attachment 154980 [details] updated Clearing flags on attachment: 154980 Committed r123891: <http://trac.webkit.org/changeset/123891>
WebKit Review Bot
Comment 6 2012-07-27 11:13:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.