Bug 92510 - [BlackBerry] Should support onbeforeunload event and show confirmation dialog
Summary: [BlackBerry] Should support onbeforeunload event and show confirmation dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 08:52 PDT by Yong Li
Modified: 2012-07-27 11:13 PDT (History)
3 users (show)

See Also:

Attachments
the patch (4.03 KB, patch)
2012-07-27 08:59 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
change the name (4.10 KB, patch)
2012-07-27 10:02 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
updated (4.20 KB, patch)
2012-07-27 10:09 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-07-27 08:52:57 PDT 
Should support onbeforeunload event and show confirmation dialog
Comment 1 Yong Li 2012-07-27 08:59:15 PDT 
Created attachment 154966 [details]
the patch
Comment 2 Antonio Gomes 2012-07-27 09:47:16 PDT 
Comment on attachment 154966 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154966&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:997
> +bool WebPage::shouldClose()

this is not a good name, imo.
Comment 3 Yong Li 2012-07-27 10:02:16 PDT 
Created attachment 154979 [details]
change the name
Comment 4 Yong Li 2012-07-27 10:09:30 PDT 
Created attachment 154980 [details]
updated
Comment 5 WebKit Review Bot 2012-07-27 11:13:18 PDT 
Comment on attachment 154980 [details]
updated

Clearing flags on attachment: 154980

Committed r123891: <http://trac.webkit.org/changeset/123891>
Comment 6 WebKit Review Bot 2012-07-27 11:13:21 PDT 
All reviewed patches have been landed.  Closing bug.