| Summary: | [EFL] Dump a backtrace in case of a crash | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> | ||||||||||
| Component: | WebKit EFL | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | d-r, gyuyoung.kim, hausmann, kbalazs, lucas.de.marchi, ossy, rakuco, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 92666 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Thiago Marcos P. Santos
2012-07-27 04:26:31 PDT
Adding you guys because I'm going to use your code. :) Created attachment 154907 [details]
Patch
Comment on attachment 154907 [details]
Patch
Is this code worth sharing within WTR/InjectedBundle?
(In reply to comment #3) > (From update of attachment 154907 [details]) > Is this code worth sharing within WTR/InjectedBundle? If it is for sharing, I suggest moving it to WTF, because would like to install the same signal handlers for Tools/TestWebKitAPI/efl/InjectedBundleController.cpp. What do you think? (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 154907 [details] [details]) > > Is this code worth sharing within WTR/InjectedBundle? > > If it is for sharing, I suggest moving it to WTF, because would like to install the same signal handlers for Tools/TestWebKitAPI/efl/InjectedBundleController.cpp. > > What do you think? Moving it to a WTF helper seems reasonable to me, basically we use the same stuff everywhere: DRT, InjectedBundle, TestAPI. Comment on attachment 154907 [details]
Patch
Clearing the flags, I'm going to rework this bug.
Created attachment 155354 [details]
Patch
Comment on attachment 155354 [details] Patch Attachment 155354 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13387518 Created attachment 155533 [details]
Patch
Comment on attachment 155533 [details] Patch Attachment 155533 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13384981 Comment on attachment 155533 [details]
Patch
Dependency has landed. It is safe to merge now.
Comment on attachment 155533 [details]
Patch
rs=me.
Comment on attachment 155533 [details] Patch Rejecting attachment 155533 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ce/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [GStreamer] Live stream support is weak When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13411053 Created attachment 155608 [details]
Patch
Comment on attachment 155608 [details] Patch Clearing flags on attachment: 155608 Committed r124244: <http://trac.webkit.org/changeset/124244> All reviewed patches have been landed. Closing bug. |