| Summary: | Page object should ascertain EditorClient to be non-null | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Vivek Galatage <vivekgalatage> | ||||||
| Component: | New Bugs | Assignee: | Vivek Galatage <vivekgalatage> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | rniwa, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 90675 | ||||||||
| Attachments: |
|
||||||||
|
Description
Vivek Galatage
2012-07-26 22:28:27 PDT
Created attachment 154842 [details]
Patch
Comment on attachment 154842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154842&action=review > Source/WebCore/ChangeLog:10 > + No new tests as no change in functionality. Just addition of check to avoid crash. That's not true. If this can never cause a crash, then we don't have to do null check. If WebKit were to crash without these null checks, then there is a behavior change. Please try to come up with a test. It's okay if you could not come up with a test if it's too hard to do so but please don't say that there is no behavior change in WebKit, when there is one. Changing the title of the bug as per the IRC discussion with rniwa. Created attachment 154851 [details]
Patch
Comment on attachment 154851 [details] Patch Clearing flags on attachment: 154851 Committed r123850: <http://trac.webkit.org/changeset/123850> All reviewed patches have been landed. Closing bug. |