Bug 92457

Summary: [BlackBerry] Update sendRequestWithCredentials to use new getProxyAddress interface
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: Page LoadingAssignee: Joe Mason <joenotcharles>
Severity: Normal CC: mifenton, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Description Flags
fixed utf8/ascii
ascii version with tab removed none

Description Joe Mason 2012-07-26 22:22:35 PDT
BlackBerry::Platform::Client::getProxyAddress has been updated to return "host:port", instead of having two separate functions for host and port.  Need to update NetworkJob to use the new API.
Comment 1 Joe Mason 2012-07-27 06:07:19 PDT
Created attachment 154920 [details]
Comment 2 Yong Li 2012-07-27 08:12:28 PDT
Comment on attachment 154920 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=154920&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:690
> +        String proxyAddress = BlackBerry::Platform::Client::get()->getProxyAddress(newURL.string().utf8().data()).c_str();

Is latin1() any better than utf8() here?
Comment 3 Yong Li 2012-07-27 08:14:46 PDT
seems String::ascii() is good to use now.
Comment 4 Joe Mason 2012-07-27 08:29:32 PDT
Created attachment 154959 [details]
fixed utf8/ascii

Good catch. Changed to ascii
Comment 5 Joe Mason 2012-07-27 08:33:13 PDT
Comment on attachment 154920 [details]

Putting both the utf8 and ascii versions up for review. Let the reviewers fight it out.
Comment 6 WebKit Review Bot 2012-07-27 08:34:29 PDT
Attachment 154959 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Yong Li 2012-07-27 08:38:04 PDT
Comment on attachment 154959 [details]
fixed utf8/ascii

cancel committing for now. there is style error
Comment 8 Joe Mason 2012-07-27 08:48:30 PDT
Created attachment 154965 [details]
ascii version with tab removed

Fixed style error
Comment 9 WebKit Review Bot 2012-07-27 08:58:19 PDT
Comment on attachment 154959 [details]
fixed utf8/ascii

Cleared Yong Li's review+ from obsolete attachment 154959 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 10 Joe Mason 2012-07-27 09:15:04 PDT
Comment on attachment 154920 [details]

Clearing review flag as the other version is being committed
Comment 11 WebKit Review Bot 2012-07-27 11:05:02 PDT
Comment on attachment 154965 [details]
ascii version with tab removed

Clearing flags on attachment: 154965

Committed r123890: <http://trac.webkit.org/changeset/123890>
Comment 12 WebKit Review Bot 2012-07-27 11:05:05 PDT
All reviewed patches have been landed.  Closing bug.