Summary: | [BlackBerry] Update sendRequestWithCredentials to use new getProxyAddress interface | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joe Mason <joenotcharles> | ||||||||
Component: | Page Loading | Assignee: | Joe Mason <joenotcharles> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | mifenton, webkit.review.bot, yong.li.webkit | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Other | ||||||||||
Attachments: |
|
Description
Joe Mason
2012-07-26 22:22:35 PDT
Created attachment 154920 [details]
patch
Comment on attachment 154920 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154920&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:690 > + String proxyAddress = BlackBerry::Platform::Client::get()->getProxyAddress(newURL.string().utf8().data()).c_str(); Is latin1() any better than utf8() here? seems String::ascii() is good to use now. Created attachment 154959 [details]
fixed utf8/ascii
Good catch. Changed to ascii
Comment on attachment 154920 [details]
patch
Putting both the utf8 and ascii versions up for review. Let the reviewers fight it out.
Attachment 154959 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 154959 [details]
fixed utf8/ascii
cancel committing for now. there is style error
Created attachment 154965 [details]
ascii version with tab removed
Fixed style error
Comment on attachment 154959 [details] fixed utf8/ascii Cleared Yong Li's review+ from obsolete attachment 154959 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 154920 [details]
patch
Clearing review flag as the other version is being committed
Comment on attachment 154965 [details] ascii version with tab removed Clearing flags on attachment: 154965 Committed r123890: <http://trac.webkit.org/changeset/123890> All reviewed patches have been landed. Closing bug. |