| Summary: | [chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Labour <piman> | ||||||
| Component: | New Bugs | Assignee: | Antoine Labour <piman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cc-bugs, danakj, jamesr, senorblanco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 92453 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antoine Labour
2012-07-26 21:07:58 PDT
Created attachment 154828 [details]
Patch
FYI, https://bugs.webkit.org/show_bug.cgi?id=92453 adds tests for this, but since it may incur some discussions / runaway refactoring, I wanted to separate this part because it's needed soon. Attachment 154828 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 154828 [details]
Patch
Looks good (once style bot is happy). I'll take a look at your other patch on Monday. r=me
Created attachment 155048 [details]
Patch for landing
Comment on attachment 155048 [details] Patch for landing Clearing flags on attachment: 155048 Committed r123932: <http://trac.webkit.org/changeset/123932> All reviewed patches have been landed. Closing bug. |