| Summary: | nrwt: remove 'webkit.py' and the 'WebKitPort' | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, eric, ojan, rniwa, tony | ||||||||
| Priority: | P2 | Keywords: | NRWT | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 92447 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dirk Pranke
2012-07-26 19:35:50 PDT
Created attachment 154814 [details]
Patch
Created attachment 154817 [details]
clarify that this is just cut&paste
adam, eric, ryoksuke - this should make you guys happy :). Comment on attachment 154817 [details] clarify that this is just cut&paste View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review It seems like you've merged your patch for the bug 92447 here. > Tools/ChangeLog:86 > +2012-07-26 Dirk Pranke <dpranke@chromium.org> > + > + nrwt: move image diffing code to a separate module > + https://bugs.webkit.org/show_bug.cgi?id=92447 Double entry. Created attachment 154835 [details]
fix base for diff
(In reply to comment #4) > (From update of attachment 154817 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154817&action=review > > It seems like you've merged your patch for the bug 92447 here. > whoops. I had it right in the first patch but forgot to specify the base for the diff in the second :(. Thanks! Comment on attachment 154835 [details] fix base for diff View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review This looks right. Please make sure that test-webkitpy & run-webkit-tests run without errors before you land. > Tools/Scripts/webkitpy/layout_tests/port/base.py:1430 > + def _skipped_tests_for_unsupported_features(self, test_list): On my.... This function has waaay too much comment that I can't make sense of the code. Could you insert some blank lines so that comments and code aren't mangled together? It's impossible to read as is. > Tools/Scripts/webkitpy/layout_tests/port/base.py:1459 > + def _skipped_file_search_paths(self): Ditto about code & comments completely mangled together. Comment on attachment 154835 [details] fix base for diff View in context: https://bugs.webkit.org/attachment.cgi?id=154835&action=review >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1430 >> + def _skipped_tests_for_unsupported_features(self, test_list): > > On my.... This function has waaay too much comment that I can't make sense of the code. > Could you insert some blank lines so that comments and code aren't mangled together? > It's impossible to read as is. sure, will do. >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1459 >> + def _skipped_file_search_paths(self): > > Ditto about code & comments completely mangled together. ok. Committed r123916: <http://trac.webkit.org/changeset/123916> |