Bug 92449

Summary: [Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-*
Product: WebKit Reporter: yosin
Component: Tools / TestsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2 tkent: review+

yosin
Reported 2012-07-26 19:25:17 PDT
For consistency, number-validitystate-range-overflow.html should be number-validity-state-range-overflow.html. Sorry, I missed this renaming at r123302.
Attachments
Patch (9.56 KB, patch)
2012-07-26 20:27 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (72.15 KB, patch)
2012-07-26 20:59 PDT, yosin 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-07-26 20:27:58 PDT
Created attachment 154823 [details] Patch
yosin
Comment 2 2012-07-26 20:29:16 PDT
Comment on attachment 154823 [details] Patch Could you review this patch? Thanks in advance. The "Diff" is result of "svn move" command.
Kent Tamura
Comment 3 2012-07-26 20:37:58 PDT
I overlooked an issue of the previous patch. I don't think they should be named as number-validity-state-*.html. They test 'validity' IDL attribute of number input element, or they test 'ValidityState' DOM interface for number input element. I prefer number-validity-rangeOverflow.html because it matches IDL attribute names, or number-validity-rangeoverflow.html if you like lowercase.
yosin
Comment 4 2012-07-26 20:55:12 PDT
Renamed obey following rules: 1. Use lower case letters only. mixing case letters may cause some issue in Windows. 2 No dash for IDL attribute name. We've been using "valueasnumber", "stepup", "stepdown" and so on.
yosin
Comment 5 2012-07-26 20:59:48 PDT
Created attachment 154826 [details] Patch 2
yosin
Comment 6 2012-07-26 21:01:52 PDT
Comment on attachment 154826 [details] Patch 2 Could you review this patch? Thanks in advance. Note: The "Diff" is result of "svn move". = Changes since the last review = * Rename *-validity-state-*- to *-validity-* for fast/forms/number and fast/forms/time
Kent Tamura
Comment 7 2012-07-26 21:04:19 PDT
Comment on attachment 154826 [details] Patch 2 ok, thanks.
yosin
Comment 8 2012-07-26 21:08:45 PDT
Landed: http://trac.webkit.org/changeset/123836
Note You need to log in before you can comment on or make changes to this bug.