Summary: | [Tests] Rename fast/forms/{number,time}/*-validity-state-* to *-validity-* | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | yosin | ||||||
Component: | Tools / Tests | Assignee: | yosin | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
yosin
2012-07-26 19:25:17 PDT
Created attachment 154823 [details]
Patch
Comment on attachment 154823 [details]
Patch
Could you review this patch?
Thanks in advance.
The "Diff" is result of "svn move" command.
I overlooked an issue of the previous patch. I don't think they should be named as number-validity-state-*.html. They test 'validity' IDL attribute of number input element, or they test 'ValidityState' DOM interface for number input element. I prefer number-validity-rangeOverflow.html because it matches IDL attribute names, or number-validity-rangeoverflow.html if you like lowercase. Renamed obey following rules: 1. Use lower case letters only. mixing case letters may cause some issue in Windows. 2 No dash for IDL attribute name. We've been using "valueasnumber", "stepup", "stepdown" and so on. Created attachment 154826 [details]
Patch 2
Comment on attachment 154826 [details]
Patch 2
Could you review this patch?
Thanks in advance.
Note: The "Diff" is result of "svn move".
= Changes since the last review =
* Rename *-validity-state-*- to *-validity-* for fast/forms/number and fast/forms/time
Comment on attachment 154826 [details]
Patch 2
ok, thanks.
|