Bug 92420

Summary: Allocate Structures in a separate part of the Heap
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Mark Hahnenberg
Reported 2012-07-26 13:39:59 PDT
To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate part of the Heap that will be swept after all other objects.
Attachments
Patch (17.28 KB, patch)
2012-07-26 15:28 PDT, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-07-26 13:40:52 PDT
This first patch will just be separating Structures out into their own separate MarkedAllocator. Everything else will behave identically.
Filip Pizlo
Comment 2 2012-07-26 13:42:51 PDT
(In reply to comment #0) > To fix our issue with destruction/finalization of Structures before their objects, we can move Structures to a separate part of the Heap that will be swept after all other objects. I like this approach! It also enables us to compress structure pointers in various sneaky ways even if we don't do it for all pointers.
Mark Hahnenberg
Comment 3 2012-07-26 15:28:05 PDT
Created attachment 154769 [details] Patch
Filip Pizlo
Comment 4 2012-07-26 15:30:22 PDT
Comment on attachment 154769 [details] Patch seems reasonable
Mark Hahnenberg
Comment 5 2012-07-26 16:28:15 PDT
Committed r123813: <http://trac.webkit.org/changeset/123813>
Note You need to log in before you can comment on or make changes to this bug.