Bug 92404

Summary:

[BlackBerry] Add timing logs to SelectionHandler.

Product:

WebKit

Reporter:

Mike Fenton <mifenton>

Component:

WebKit BlackBerry

Assignee:

Mike Fenton <mifenton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix style in patch.	none

Mike Fenton

Reported 2012-07-26 11:23:24 PDT

SSIA.

Attachments
Patch (4.71 KB, patch) 2012-07-26 11:33 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Fix style in patch. (4.72 KB, patch) 2012-07-26 11:45 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike Fenton

Comment 1 2012-07-26 11:33:15 PDT

Created attachment 154704 [details] Patch

WebKit Review Bot

Comment 2 2012-07-26 11:36:34 PDT

Attachment 154704 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h:24: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mike Fenton

Comment 3 2012-07-26 11:45:21 PDT

Created attachment 154706 [details] Fix style in patch.

Rob Buis

Comment 4 2012-07-26 11:51:02 PDT

Comment on attachment 154706 [details] Fix style in patch. Looks good.

WebKit Review Bot

Comment 5 2012-07-26 13:20:02 PDT

Comment on attachment 154706 [details] Fix style in patch. Clearing flags on attachment: 154706 Committed r123787: <http://trac.webkit.org/changeset/123787>

WebKit Review Bot

Comment 6 2012-07-26 13:20:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.