Bug 92379 – Web Inspector: make MemoryInstrumentation methods private

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Yury Semikhatsky]

The only way to report an object should be either MemoryInstrumentation::addObject or  MemoryInstrumentation::addInstrumentedObject.

[Yury Semikhatsky]

Created attachment 154646 [details]
Patch

[Yury Semikhatsky]

Created attachment 154650 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 154646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154646&action=review

> Source/WebCore/dom/MemoryInstrumentation.h:65
> -    template <typename T> void addMember(const T& t, ObjectType objectType)
> +    template <typename T> void addObject(const T& t, ObjectType objectType)
>      {
> -        OwningTraits<T>::addMember(this, t, objectType);
> +        OwningTraits<T>::addObject(this, t, objectType);
>      }

I see that we never call addObject from places other than MemoryClassInfo. Please move it to private area.

[Early Warning System Bot]

Comment on attachment 154646 [details]
Patch

Attachment 154646 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13339771

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 154646 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154646&action=review
> 
> > Source/WebCore/dom/MemoryInstrumentation.h:65
> > -    template <typename T> void addMember(const T& t, ObjectType objectType)
> > +    template <typename T> void addObject(const T& t, ObjectType objectType)
> >      {
> > -        OwningTraits<T>::addMember(this, t, objectType);
> > +        OwningTraits<T>::addObject(this, t, objectType);
> >      }
> 
> I see that we never call addObject from places other than MemoryClassInfo. Please move it to private area.

Done.

[Early Warning System Bot]

Comment on attachment 154650 [details]
Patch

Attachment 154650 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13353751

[Gyuyoung Kim]

Comment on attachment 154650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154650&action=review

Don't you need to set "Depend on Bug 92359" ?

> Source/WebCore/dom/MemoryInstrumentation.cpp:32
> +

Nit : in my humble opinion, header file is placed just below config.h without an empty line generally.

[Yury Semikhatsky]

(In reply to comment #7)
> (From update of attachment 154650 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154650&action=review
> 
> Don't you need to set "Depend on Bug 92359" ?
> 
Done.

> > Source/WebCore/dom/MemoryInstrumentation.cpp:32
> > +
> 
> Nit : in my humble opinion, header file is placed just below config.h without an empty line generally.

Done.

[Yury Semikhatsky]

Created attachment 155238 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 155238 [details]
Patch

lgtm

[Early Warning System Bot]

Comment on attachment 155238 [details]
Patch

Attachment 155238 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13381719

[Early Warning System Bot]

Comment on attachment 155238 [details]
Patch

Attachment 155238 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13401010

[Build Bot]

Comment on attachment 155238 [details]
Patch

Attachment 155238 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13394264

[WebKit Review Bot]

Comment on attachment 155238 [details]
Patch

Attachment 155238 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13393296

New failing tests:
platform/chromium/compositing/accelerated-drawing/svg-filters.html
platform/chromium/compositing/accelerated-drawing/alpha.html

[WebKit Review Bot]

Created attachment 155249 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Yury Semikhatsky]

Created attachment 155262 [details]
Patch for landing

Fixed Qt and Win build files.

[WebKit Review Bot]

Comment on attachment 155238 [details]
Patch

Cleared Vsevolod Vlasov's review+ from obsolete attachment 155238 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Yury Semikhatsky]

Committed r124017: <http://trac.webkit.org/changeset/124017>