Bug 92375

Summary: [WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
Product: WebKit Reporter: Nayan Kumar K <nayankk>
Component: WebGLAssignee: Nayan Kumar K <nayankk>
Status: RESOLVED FIXED    
Severity: Normal CC: gman, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91976    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch
none
Reworked patch
none
Rebased patch none

Nayan Kumar K
Reported 2012-07-26 06:09:42 PDT
As per the discussion in https://bugs.webkit.org/show_bug.cgi?id=91976, contents of Layouttests/canvas/webgl/drawbuffer-test.html need to be aligned with conformance/canvas/drawingbuffer-test.html in the WebGL conformance suite.
Attachments
Proposed patch (16.67 KB, patch)
2012-07-26 06:18 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Reworked patch (16.67 KB, patch)
2012-07-26 22:08 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Rebased patch (13.01 KB, patch)
2012-07-27 00:33 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nayan Kumar K
Comment 1 2012-07-26 06:18:00 PDT
Created attachment 154636 [details] Proposed patch
Kenneth Russell
Comment 2 2012-07-26 16:13:26 PDT
Comment on attachment 154636 [details] Proposed patch Thanks for doing this. I'm clearing the r? bit for now. Please update the patch once https://bugs.webkit.org/show_bug.cgi?id=91976 lands.
Nayan Kumar K
Comment 3 2012-07-26 22:08:43 PDT
Created attachment 154841 [details] Reworked patch
Nayan Kumar K
Comment 4 2012-07-27 00:33:01 PDT
Created attachment 154865 [details] Rebased patch
Kenneth Russell
Comment 5 2012-07-27 14:14:11 PDT
Comment on attachment 154865 [details] Rebased patch Fantastic. Thanks. r=me
WebKit Review Bot
Comment 6 2012-07-27 23:56:06 PDT
Comment on attachment 154865 [details] Rebased patch Clearing flags on attachment: 154865 Committed r123956: <http://trac.webkit.org/changeset/123956>
WebKit Review Bot
Comment 7 2012-07-27 23:56:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.