Bug 92373

Summary:

Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Description Vsevolod Vlasov 2012-07-26 05:54:14 PDT

Patch to follow

Comment 1 Vsevolod Vlasov 2012-07-26 05:54:59 PDT

This change will allow us to support CSS formatting and simplify UISourceCode code.

Comment 2 Vsevolod Vlasov 2012-07-26 07:24:26 PDT

Created attachment 154649 [details]
Patch

Comment 3 Pavel Feldman 2012-07-26 08:59:04 PDT

Comment on attachment 154649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154649&action=review

> Source/WebCore/inspector/front-end/JavaScriptSource.js:51
>      uiLocationToRawLocation: function(lineNumber, columnNumber)

I don't think you need this method.

> Source/WebCore/inspector/front-end/Script.js:223
> +    uiLocation: function()

This looks like a great self-contained change.

> Source/WebCore/inspector/front-end/ScriptFormatter.js:35
> +WebInspector.Formatter = function(workerURL)

I don't think we should imply that the formatter is implemented using worker.

> Source/WebCore/inspector/front-end/UISourceCode.js:411
> +    uiLocationToRawLocation: function(lineNumber, columnNumber)

You should move it back.

Comment 4 Vsevolod Vlasov 2012-07-27 01:50:57 PDT

Committed r123852: <http://trac.webkit.org/changeset/123852>