Bug 92336

Summary: Add a MediaPlayer API to retrieve the description of the current media engine.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gustavo, menard, mfeil, mifenton, mrobinson, noam, pnormand, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 92341    
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2012-07-25 23:16:52 PDT
Add a MediaPlayer API to retrieve the description of the current media engine.
Attachments
Patch (7.59 KB, patch)
2012-07-25 23:55 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-07-25 23:55:04 PDT
Created attachment 154555 [details] Patch
Eric Carlson
Comment 2 2012-07-26 05:41:57 PDT
Comment on attachment 154555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154555&action=review How about platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h? You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug. > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:134 > + virtual String engineDescription() const { return ""; } Did you mean to leave this blank?
Jer Noble
Comment 3 2012-07-26 07:56:30 PDT
(In reply to comment #2) > (From update of attachment 154555 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154555&action=review > > How about platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h? Yep, missed that one. I'll add it. > You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug. Might as well just do it in this patch. > > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:134 > > + virtual String engineDescription() const { return ""; } > > Did you mean to leave this blank? Nope, I'll fill that one in too. Thanks!
Jer Noble
Comment 4 2012-07-26 07:59:37 PDT
(In reply to comment #3) > (In reply to comment #2) > > You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug. > > Might as well just do it in this patch. Nevermind, I'll file a bug.
Jer Noble
Comment 5 2012-07-26 08:10:27 PDT
Committed r123747: <http://trac.webkit.org/changeset/123747>
Note You need to log in before you can comment on or make changes to this bug.