Bug 92326

Summary: Web Inspector: ExtensionView constructor shouldn't take parent argument
Product: WebKit Reporter: Jan Keromnes <janx>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Jan Keromnes 2012-07-25 18:13:09 PDT 
ExtensionView's constructor takes a parent argument and directly calls `this.show(parent)` at the end of the constructor. This is problematic if you're creating and ExtensionView but you don't want to show it right away or you don't know about its parent element yet. The correct behavior should be the same as for View objects: do not take `parent` as a constructor argument, wait for a call to `extensionView.show(parent)` whenever needed.
Comment 1 Jan Keromnes 2012-07-25 18:59:59 PDT 
Created attachment 154517 [details]
Patch
Comment 2 Andrey Kosyakov 2012-07-26 06:12:02 PDT 
Comment on attachment 154517 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2012-07-26 09:12:53 PDT 
Comment on attachment 154517 [details]
Patch

Clearing flags on attachment: 154517

Committed r123753: <http://trac.webkit.org/changeset/123753>
Comment 4 WebKit Review Bot 2012-07-26 09:12:58 PDT 
All reviewed patches have been landed.  Closing bug.