| Summary: | flex-wrap: wrap not wrapping for % sized items in column flow | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Scott Miles <sjmiles> | ||||||||||
| Component: | CSS | Assignee: | Tony Chang <tony> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, eric, ojan, sjmiles, tony, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac (Intel) | ||||||||||||
| OS: | OS X 10.7 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 62048 | ||||||||||||
| Attachments: |
|
||||||||||||
Yup, definitely a bug. Created attachment 154786 [details]
Patch
Comment on attachment 154786 [details] Patch Attachment 154786 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13369269 New failing tests: css3/flexbox/percentage-heights.html Created attachment 154861 [details]
Archive of layout-test-results from gce-cr-linux-07
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 154994 [details]
Patch for landing
(In reply to comment #3) > (From update of attachment 154786 [details]) > Attachment 154786 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13369269 > > New failing tests: > css3/flexbox/percentage-heights.html I'm dumb. I had changed the height/width properties of the flexbox to min-height/min-width because I was testing if I needed to handle that. I forgot to change it back when I uploaded the diff. I'll let the commit queue land this to verify that the new test is correct. Comment on attachment 154994 [details] Patch for landing Clearing flags on attachment: 154994 Committed r123909: <http://trac.webkit.org/changeset/123909> All reviewed patches have been landed. Closing bug. |
Created attachment 154502 [details] flex-wrap samples highlighting failing configuration %-sized flex items not wrapping under flex-flow: column wrap (they do in fact wrap under flex-flow: row wrap)