Bug 92286

Summary: Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, japhet, jochen, rakuco, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2012-07-25 13:17:11 PDT
Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
Attachments
Patch (15.35 KB, patch)
2012-07-25 13:22 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (15.72 KB, patch)
2012-07-25 13:33 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (17.16 KB, patch)
2012-07-30 15:16 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (18.95 KB, patch)
2012-07-31 13:14 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (19.07 KB, patch)
2012-08-01 06:58 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-07-25 13:22:13 PDT
Created attachment 154424 [details] Patch
WebKit Review Bot
Comment 2 2012-07-25 13:25:42 PDT
Attachment 154424 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1 Source/WebCore/html/FTPDirectoryDocument.cpp:233: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/html/FTPDirectoryDocument.cpp:233: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2012-07-25 13:27:50 PDT
Comment on attachment 154424 [details] Patch Attachment 154424 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13350352
Patrick R. Gansterer
Comment 4 2012-07-25 13:33:10 PDT
Created attachment 154425 [details] Patch
WebKit Review Bot
Comment 5 2012-07-25 13:35:13 PDT
Attachment 154425 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1 Source/WebCore/html/FTPDirectoryDocument.cpp:234: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/html/FTPDirectoryDocument.cpp:234: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 6 2012-07-30 15:16:23 PDT
Created attachment 155379 [details] Patch
WebKit Review Bot
Comment 7 2012-07-30 15:19:05 PDT
Attachment 155379 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmak..." exit_code: 1 Source/WebCore/html/FTPDirectoryDocument.cpp:234: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/html/FTPDirectoryDocument.cpp:234: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 8 2012-07-30 20:54:48 PDT
Comment on attachment 155379 [details] Patch Attachment 155379 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13401270
Patrick R. Gansterer
Comment 9 2012-07-31 13:14:22 PDT
Created attachment 155616 [details] Patch
WebKit Review Bot
Comment 10 2012-07-31 13:16:58 PDT
Attachment 155616 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/html/FTPDirectoryDocument.cpp:234: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/html/FTPDirectoryDocument.cpp:234: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 11 2012-08-01 06:58:55 PDT
Created attachment 155802 [details] Patch
WebKit Review Bot
Comment 12 2012-08-01 07:03:12 PDT
Attachment 155802 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/html/FTPDirectoryDocument.cpp:234: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/html/FTPDirectoryDocument.cpp:234: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 13 2012-08-01 12:05:30 PDT
Comment on attachment 155802 [details] Patch r=me
WebKit Review Bot
Comment 14 2012-08-01 13:49:44 PDT
Comment on attachment 155802 [details] Patch Clearing flags on attachment: 155802 Committed r124365: <http://trac.webkit.org/changeset/124365>
WebKit Review Bot
Comment 15 2012-08-01 13:49:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.