Bug 92277

Summary:

[chromium] move EventSender into TestRunner.a

Product:

WebKit

Reporter:

jochen

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

92256

Bug Blocks:

91308

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cq-02	none
Archive of layout-test-results from gce-cq-02	none
Patch	none
Patch for landing	none

Description jochen 2012-07-25 12:23:40 PDT

EventSender doesn't depend on WebViewHost anymore, so it can go into TestRunner

Comment 1 jochen 2012-07-25 12:26:18 PDT

Created attachment 154416 [details]
Patch

Comment 2 jochen 2012-07-25 12:27:12 PDT

the patch depends on https://bugs.webkit.org/show_bug.cgi?id=92256 which is currently in the CQ

Comment 3 WebKit Review Bot 2012-07-25 15:15:17 PDT

Comment on attachment 154416 [details]
Patch

Rejecting attachment 154416 [details] from commit-queue.

New failing tests:
plugins/keyboard-events.html
Full output: http://queues.webkit.org/results/13345375

Comment 4 WebKit Review Bot 2012-07-25 15:15:20 PDT

Created attachment 154458 [details]
Archive of layout-test-results from gce-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 5 WebKit Review Bot 2012-07-25 16:59:35 PDT

Comment on attachment 154416 [details]
Patch

Rejecting attachment 154416 [details] from commit-queue.

New failing tests:
plugins/keyboard-events.html
Full output: http://queues.webkit.org/results/13346455

Comment 6 WebKit Review Bot 2012-07-25 16:59:38 PDT

Created attachment 154490 [details]
Archive of layout-test-results from gce-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 7 jochen 2012-07-31 04:38:46 PDT

Created attachment 155493 [details]
Patch

Comment 8 jochen 2012-07-31 04:41:30 PDT

Created attachment 155494 [details]
Patch for landing

Comment 9 WebKit Review Bot 2012-07-31 06:02:56 PDT

Comment on attachment 155494 [details]
Patch for landing

Clearing flags on attachment: 155494

Committed r124195: <http://trac.webkit.org/changeset/124195>

Comment 10 WebKit Review Bot 2012-07-31 06:03:00 PDT

All reviewed patches have been landed.  Closing bug.