Bug 92265 – Web Inspector: SASS source mapping straw man (behind experiment)

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

This change introduces SASS mapping support (behind the experiment).

[Pavel Feldman]

Created attachment 154382 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 154382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:51
> +        function populateFrame(frame)

We seem to have a few similar hand-written traversals - might warrant a visitor...

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:83
> +            var regex = /@media\s\-sass\-debug\-info{filename{font-family:([^}]+)}line{font-family:\\[0]+([^}]*)}}/i;

"[0]" does not need the square brackets around '0' (if I'm reading it correctly as a single-character class).

> Source/WebCore/inspector/front-end/ScriptsPanel.js:-472
> -

seems like a stray change

[Vsevolod Vlasov]

Comment on attachment 154382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:98
> +                var rawLocation = resource.url + ":" + (lineNumber + 1);

Please use another name (e.g. rawLocationString or rawLocationId) for this variable as it is not a RawLocation.

> Source/WebCore/inspector/front-end/SASSSourceMapping.js:128
> +        return new WebInspector.CSSLocation(uiSourceCode.contentURL() || "", lineNumber);

Please add a FIXME: comment saying this is a stub implementation

[Pavel Feldman]

Committed r123768: <http://trac.webkit.org/changeset/123768>