| Summary: | Web Inspector: SASS source mapping straw man (behind experiment) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2012-07-25 10:14:25 PDT
Created attachment 154382 [details]
Patch
Comment on attachment 154382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review > Source/WebCore/inspector/front-end/SASSSourceMapping.js:51 > + function populateFrame(frame) We seem to have a few similar hand-written traversals - might warrant a visitor... > Source/WebCore/inspector/front-end/SASSSourceMapping.js:83 > + var regex = /@media\s\-sass\-debug\-info{filename{font-family:([^}]+)}line{font-family:\\[0]+([^}]*)}}/i; "[0]" does not need the square brackets around '0' (if I'm reading it correctly as a single-character class). > Source/WebCore/inspector/front-end/ScriptsPanel.js:-472 > - seems like a stray change Comment on attachment 154382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154382&action=review > Source/WebCore/inspector/front-end/SASSSourceMapping.js:98 > + var rawLocation = resource.url + ":" + (lineNumber + 1); Please use another name (e.g. rawLocationString or rawLocationId) for this variable as it is not a RawLocation. > Source/WebCore/inspector/front-end/SASSSourceMapping.js:128 > + return new WebInspector.CSSLocation(uiSourceCode.contentURL() || "", lineNumber); Please add a FIXME: comment saying this is a stub implementation Committed r123768: <http://trac.webkit.org/changeset/123768> |