| Summary: | Build fix with newer bison 2.6. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||||||
| Component: | XML | Assignee: | Alexis Menard (darktears) <menard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, anthony, cmarcelo, dennis.yxun, eric, floppymaster, gnome, macpherson, tomi.kyostila, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexis Menard (darktears)
2012-07-25 10:07:55 PDT
Created attachment 154381 [details]
Patch
*** Bug 91943 has been marked as a duplicate of this bug. *** (In reply to comment #2) > *** Bug 91943 has been marked as a duplicate of this bug. *** According to the bug in fact the bison output is different. Comment on attachment 154381 [details]
Patch
Clearing flags for now.
Comment on attachment 154381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review > Source/WebCore/ChangeLog:3 > + Build fix with GCC 4.7.1 The bug title is different now. (In reply to comment #5) > (From update of attachment 154381 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review > > > Source/WebCore/ChangeLog:3 > > + Build fix with GCC 4.7.1 > > The bug title is different now. I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf. (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 154381 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=154381&action=review > > > > > Source/WebCore/ChangeLog:3 > > > + Build fix with GCC 4.7.1 > > > > The bug title is different now. > > I know that's why I cleared the review flags. I will re upload a version but I'm making further investigation on the generated file of gperf. sorry bison* The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here. Created attachment 154637 [details]
Patch
(In reply to comment #9) > Created an attachment (id=154637) [details] > Patch Let's see EWS before asking for review. I'll give a shot on a Mac as EWS Mac is out of service for the moment. Attachment 154637 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 154643 [details]
Patch
(In reply to comment #8) > The release notes for bison 2.6 mention that the YYPARSE_PARAM macro has be deprecated. That might be a good place to start here. That's what the last patch is addressing. Attachment 154643 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/xml/XPathParser.cpp:45: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Is someone going to commit this? :) Comment on attachment 154643 [details]
Patch
Ok
Comment on attachment 154643 [details] Patch Clearing flags on attachment: 154643 Committed r124099: <http://trac.webkit.org/changeset/124099> All reviewed patches have been landed. Closing bug. |