Bug 92259

Summary:

Web Inspector: add memory reporting routine to StyleResolver

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, cmarcelo, joepeck, keishi, koivisto, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

87262

Attachments:

Description	Flags
Patch	none
Patch	none

Yury Semikhatsky

Reported 2012-07-25 08:38:47 PDT

Memory consumed by StyleResolver should be accounted as part of the CSS component.

Attachments
Patch (12.09 KB, patch) 2012-07-25 08:47 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (12.12 KB, patch) 2012-07-25 09:39 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-07-25 08:47:34 PDT

Created attachment 154369 [details] Patch

Early Warning System Bot

Comment 2 2012-07-25 09:28:08 PDT

Comment on attachment 154369 [details] Patch Attachment 154369 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13348275

Yury Semikhatsky

Comment 3 2012-07-25 09:39:09 PDT

Created attachment 154374 [details] Patch

Ilya Tikhonovsky

Comment 4 2012-07-25 09:54:02 PDT

Comment on attachment 154374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review > Source/WebCore/css/StyleResolver.cpp:2516 > + info->addInstrumentedVector(*it->second); I'd expect that you report the key too. > Source/WebCore/css/StyleResolver.cpp:5659 > + // FIXME: move this to a place where it would be called only once? > + info.addInstrumentedMember(defaultStyle); > + info.addInstrumentedMember(defaultQuirksStyle); > + info.addInstrumentedMember(defaultPrintStyle); > + info.addInstrumentedMember(defaultViewSourceStyle); What about other statics static StyleSheetContents* simpleDefaultStyleSheet; static StyleSheetContents* defaultStyleSheet; static StyleSheetContents* quirksStyleSheet; static StyleSheetContents* svgStyleSheet; static StyleSheetContents* mathMLStyleSheet; static StyleSheetContents* mediaControlsStyleSheet; static StyleSheetContents* fullscreenStyleSheet;

Yury Semikhatsky

Comment 5 2012-07-25 10:17:19 PDT

(In reply to comment #4) > (From update of attachment 154374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review > > What about other statics > > static StyleSheetContents* simpleDefaultStyleSheet; > static StyleSheetContents* defaultStyleSheet; > static StyleSheetContents* quirksStyleSheet; > static StyleSheetContents* svgStyleSheet; > static StyleSheetContents* mathMLStyleSheet; > static StyleSheetContents* mediaControlsStyleSheet; > static StyleSheetContents* fullscreenStyleSheet; StyleSheetContents is not instrumented yet. I'm going to take care of it in another patch.

Ilya Tikhonovsky

Comment 6 2012-07-26 01:18:48 PDT

Comment on attachment 154374 [details] Patch lgtm

WebKit Review Bot

Comment 7 2012-07-26 03:42:49 PDT

Comment on attachment 154374 [details] Patch Clearing flags on attachment: 154374 Committed r123726: <http://trac.webkit.org/changeset/123726>

WebKit Review Bot

Comment 8 2012-07-26 03:42:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.