Summary: | Web Inspector: add memory reporting routine to StyleResolver | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, cmarcelo, joepeck, keishi, koivisto, loislo, macpherson, menard, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 87262 | ||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-07-25 08:38:47 PDT
Created attachment 154369 [details]
Patch
Comment on attachment 154369 [details] Patch Attachment 154369 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13348275 Created attachment 154374 [details]
Patch
Comment on attachment 154374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review > Source/WebCore/css/StyleResolver.cpp:2516 > + info->addInstrumentedVector(*it->second); I'd expect that you report the key too. > Source/WebCore/css/StyleResolver.cpp:5659 > + // FIXME: move this to a place where it would be called only once? > + info.addInstrumentedMember(defaultStyle); > + info.addInstrumentedMember(defaultQuirksStyle); > + info.addInstrumentedMember(defaultPrintStyle); > + info.addInstrumentedMember(defaultViewSourceStyle); What about other statics static StyleSheetContents* simpleDefaultStyleSheet; static StyleSheetContents* defaultStyleSheet; static StyleSheetContents* quirksStyleSheet; static StyleSheetContents* svgStyleSheet; static StyleSheetContents* mathMLStyleSheet; static StyleSheetContents* mediaControlsStyleSheet; static StyleSheetContents* fullscreenStyleSheet; (In reply to comment #4) > (From update of attachment 154374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154374&action=review > > What about other statics > > static StyleSheetContents* simpleDefaultStyleSheet; > static StyleSheetContents* defaultStyleSheet; > static StyleSheetContents* quirksStyleSheet; > static StyleSheetContents* svgStyleSheet; > static StyleSheetContents* mathMLStyleSheet; > static StyleSheetContents* mediaControlsStyleSheet; > static StyleSheetContents* fullscreenStyleSheet; StyleSheetContents is not instrumented yet. I'm going to take care of it in another patch. Comment on attachment 154374 [details]
Patch
lgtm
Comment on attachment 154374 [details] Patch Clearing flags on attachment: 154374 Committed r123726: <http://trac.webkit.org/changeset/123726> All reviewed patches have been landed. Closing bug. |