Bug 92256 – [chromium] don't use webkit_support methods directly from test runners but through the test delegate

• Component: New Bugs
• Status: RESOLVED FIXED

[chromium] don't use webkit_support methods directly from test runners but through the test delegate

Created attachment 154360 [details]
Patch

[Adam Barth]

Comment on attachment 154360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154360&action=review

> Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h:63
> -    WebKit::WebGamepads internalData;
> +    WebKit::WebGamepads m_internalData;

m_internalData is such a terrible name.  How about m_gamepads?

> Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:73
> -    // m_gamepadController doesn't depend on WebView.
> +    m_gamepadController->setDelegate(0);

I would start a new stanza for setDelegate(0) below the setWebView(0) stanza.

Created attachment 154401 [details]
Patch for landing

(In reply to comment #2)
> (From update of attachment 154360 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154360&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/GamepadController.h:63
> > -    WebKit::WebGamepads internalData;
> > +    WebKit::WebGamepads m_internalData;
> 
> m_internalData is such a terrible name.  How about m_gamepads?

sg

> 
> > Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:73
> > -    // m_gamepadController doesn't depend on WebView.
> > +    m_gamepadController->setDelegate(0);
> 
> I would start a new stanza for setDelegate(0) below the setWebView(0) stanza.

done

[WebKit Review Bot]

Comment on attachment 154401 [details]
Patch for landing

Clearing flags on attachment: 154401

Committed r123661: <http://trac.webkit.org/changeset/123661>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.