Bug 92230 – [Forms] Move HTMLInputElement::updateInnerTextValue to InputType class

• Component: Forms
• Status: RESOLVED FIXED

To implement, multiple field time input UI, we need to tell TimeInputType about changing value. This can be done by making HTMLInputElement::updateInnerTextValue() to call InputType::updateInnerValue().

Here is list of call site of updateInnerTextValue()
 - DateInputValue::handleBlurEvent()
 - HTMLInputElement::copyNonAttributePropertiesFromElement()
 - HTMLInputElement::parseAttribute() -- for changing value via setAttribute()
 - HTMLInputElement::setSuggestedValue()
 - HTMLInputElement::updateType()
 - NumberInputType::handleBlurEvent()
 - TextFieldInputType::setValue()

Created attachment 154295 [details]
Patch 1

Comment on attachment 154295 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Comment on attachment 154295 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=154295&action=review

> Source/WebCore/html/HTMLInputElement.cpp:493
>  void HTMLInputElement::updateInnerTextValue()
>  {

Please remove HTMLInputElement::updateInnerTextValue().

> Source/WebCore/html/InputType.h:262
> +    virtual void updateInnerValue() { }

Do not define function body in a header for virtual functions.  It wastes build time.

> Source/WebCore/html/TextFieldInputType.cpp:453
> +void TextFieldInputType::updateInnerValue()

The function name should be updateInnerTextValue() because of consistency with 'innerText' functions though I don't like this name.

Created attachment 154309 [details]
Patch 1

Comment on attachment 154309 [details]
Patch 1

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Remove HTMLInputElement::updateInnerTextValue()
* Update call sites of HTMLInputElement::updateInnerTextValue()
* Use InputType::updateInnerTextValue() instead of updateInnerValue()

[Kent Tamura]

Comment on attachment 154309 [details]
Patch 1

ok

Comment on attachment 154309 [details]
Patch 1

Clearing flags on attachment: 154309

Committed r123687: <http://trac.webkit.org/changeset/123687>

All reviewed patches have been landed.  Closing bug.