Bug 92219

Summary: [EFL][DRT] fast/loader/stop-provisional-loads.html fails
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKit EFLAssignee: Joone Hur <joone>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Joone Hur 2012-07-24 23:43:49 PDT 
We need to add the ability to tell DRT to call ewk_frame_stop inside of a didStartProvisionalLoadForFrame signal handler.
For more details, please take a look at https://trac.webkit.org/changeset/34972.
Comment 1 Joone Hur 2012-07-25 00:12:32 PDT 
Created attachment 154279 [details]
Patch
Comment 2 Chris Dumez 2012-07-25 00:17:53 PDT 
Comment on attachment 154279 [details]
Patch

As long as it does not cause regressions for other tests, LGTM. Maybe you should use [DRT] keyword in bug title.
Comment 3 Gyuyoung Kim 2012-07-25 00:25:26 PDT 
Comment on attachment 154279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review

As we talk on irc, please consider WK2 layout test as well.

> Tools/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule.
Comment 4 Chris Dumez 2012-07-25 00:29:02 PDT 
Comment on attachment 154279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154279&action=review

>> Tools/ChangeLog:10
>> +        Reviewed by NOBODY (OOPS!).
> 
> Generally, patch description is placed below *Reviewed by NOBODY*. But, this is not rule.

Right, sorry I missed that.
Comment 5 Joone Hur 2012-07-30 22:30:47 PDT 
Created attachment 155440 [details]
Patch
Comment 6 Joone Hur 2012-07-30 22:42:50 PDT 
@Christophe, @Gyuyoung: I've moved the description below *Reviewed by NOBODY* and checked that this test case already passes in WK2 test.

Thanks for the review.
Comment 7 Kenneth Rohde Christiansen 2012-08-03 04:42:56 PDT 
Comment on attachment 155440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155440&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:690
> +        const String frameName(DumpRenderTreeSupportEfl::suitableDRTFrameName(frame));

Btw Qt is getting rid for DumpRenderTreeSupportQt for a separate library. You should have a look
Comment 8 WebKit Review Bot 2012-08-03 05:16:45 PDT 
Comment on attachment 155440 [details]
Patch

Clearing flags on attachment: 155440

Committed r124599: <http://trac.webkit.org/changeset/124599>
Comment 9 WebKit Review Bot 2012-08-03 05:16:51 PDT 
All reviewed patches have been landed.  Closing bug.