| Summary: | IndexedDB: Make db.version return an integer if appropriate | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||||||
| Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, alecflett, dglazkov, jsbell, ojan, tony, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
David Grogan
2012-07-24 19:23:09 PDT
Created attachment 154230 [details]
Patch
Josh, could you take a look at this? Comment on attachment 154230 [details]
Patch
LGTM
Tony, could you review this? Comment on attachment 154230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review > Source/WebCore/ChangeLog:9 > + upgradeneeded API has been used. typo: upgradeneeded Created attachment 154240 [details]
Patch
Comment on attachment 154230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review >> Source/WebCore/ChangeLog:9 >> + upgradeneeded API has been used. > > typo: upgradeneeded Clarified. Comment on attachment 154240 [details] Patch Attachment 154240 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13349105 New failing tests: http/tests/security/script-crossorigin-loads-correctly.html fast/loader/loadInProgress.html fast/loader/unload-form-post-about-blank.html Created attachment 154256 [details]
Archive of layout-test-results from gce-cr-linux-06
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 154428 [details]
Patch
Tony, could you review this? The last patch had no changes, just rebased onto the latest trunk. It looks like the interdiff capability is gone in the new bugzilla version. Comment on attachment 154428 [details]
Patch
Can you test this using === in JS?
(In reply to comment #12) > (From update of attachment 154428 [details]) > Can you test this using === in JS? Yep. It's done a couple of places in the layout tests for integer versions, e.g. https://bugs.webkit.org/attachment.cgi?id=153651&action=review#line1842. I should have noted that this patch is a chunk broken off of that one. Comment on attachment 154428 [details] Patch Clearing flags on attachment: 154428 Committed r123683: <http://trac.webkit.org/changeset/123683> All reviewed patches have been landed. Closing bug. |