Bug 92195

Summary: IndexedDB: Make db.version return an integer if appropriate
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, jsbell, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-06
none
Patch none

David Grogan
Reported 2012-07-24 19:23:09 PDT
IndexedDB: Make db.version return an integer if appropriate
Attachments
Patch (3.17 KB, patch)
2012-07-24 20:16 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2012-07-24 21:18 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (1.02 MB, application/zip)
2012-07-24 22:46 PDT, WebKit Review Bot 		no flags
Details
Patch (3.12 KB, patch)
2012-07-25 13:36 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-07-24 20:16:02 PDT
Created attachment 154230 [details] Patch
David Grogan
Comment 2 2012-07-24 20:16:41 PDT
Josh, could you take a look at this?
Joshua Bell
Comment 3 2012-07-24 20:32:56 PDT
Comment on attachment 154230 [details] Patch LGTM
David Grogan
Comment 4 2012-07-24 20:43:05 PDT
Tony, could you review this?
Adam Barth
Comment 5 2012-07-24 21:10:30 PDT
Comment on attachment 154230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review > Source/WebCore/ChangeLog:9 > + upgradeneeded API has been used. typo: upgradeneeded
David Grogan
Comment 6 2012-07-24 21:18:59 PDT
Created attachment 154240 [details] Patch
David Grogan
Comment 7 2012-07-24 21:19:46 PDT
Comment on attachment 154230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154230&action=review >> Source/WebCore/ChangeLog:9 >> + upgradeneeded API has been used. > > typo: upgradeneeded Clarified.
WebKit Review Bot
Comment 8 2012-07-24 22:46:06 PDT
Comment on attachment 154240 [details] Patch Attachment 154240 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13349105 New failing tests: http/tests/security/script-crossorigin-loads-correctly.html fast/loader/loadInProgress.html fast/loader/unload-form-post-about-blank.html
WebKit Review Bot
Comment 9 2012-07-24 22:46:10 PDT
Created attachment 154256 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
David Grogan
Comment 10 2012-07-25 13:36:44 PDT
Created attachment 154428 [details] Patch
David Grogan
Comment 11 2012-07-25 13:39:33 PDT
Tony, could you review this? The last patch had no changes, just rebased onto the latest trunk. It looks like the interdiff capability is gone in the new bugzilla version.
Tony Chang
Comment 12 2012-07-25 15:42:01 PDT
Comment on attachment 154428 [details] Patch Can you test this using === in JS?
David Grogan
Comment 13 2012-07-25 16:00:16 PDT
(In reply to comment #12) > (From update of attachment 154428 [details]) > Can you test this using === in JS? Yep. It's done a couple of places in the layout tests for integer versions, e.g. https://bugs.webkit.org/attachment.cgi?id=153651&action=review#line1842. I should have noted that this patch is a chunk broken off of that one.
WebKit Review Bot
Comment 14 2012-07-25 17:25:20 PDT
Comment on attachment 154428 [details] Patch Clearing flags on attachment: 154428 Committed r123683: <http://trac.webkit.org/changeset/123683>
WebKit Review Bot
Comment 15 2012-07-25 17:25:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.