Bug 92114

Summary: Add methods to ColorChooserClient so the color chooser can show suggestions
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 92075    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-07-24 07:22:22 PDT
Add methods to ColorChooserClient that will be used by the color chooser to show suggestions
Attachments
Patch (4.06 KB, patch)
2012-07-24 07:29 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (5.24 KB, patch)
2012-07-24 08:06 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (5.42 KB, patch)
2012-07-24 19:06 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-07-24 07:29:47 PDT
Created attachment 154056 [details] Patch
Kent Tamura
Comment 2 2012-07-24 07:37:41 PDT
Comment on attachment 154056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154056&action=review > Source/WebCore/html/ColorInputType.cpp:215 > + return element()->fastHasAttribute(HTMLNames::listAttr); We usually declare "using namespace HTMLNames;" and omit HTMLNames::.
WebKit Review Bot
Comment 3 2012-07-24 07:56:12 PDT
Comment on attachment 154056 [details] Patch Attachment 154056 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13338269
Gyuyoung Kim
Comment 4 2012-07-24 07:59:42 PDT
Comment on attachment 154056 [details] Patch Attachment 154056 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13326464
Keishi Hattori
Comment 5 2012-07-24 08:06:28 PDT
Created attachment 154065 [details] Patch
Keishi Hattori
Comment 6 2012-07-24 08:07:02 PDT
Added includes that were missing and made HTMLInputElement::dataList() public
Kent Tamura
Comment 7 2012-07-24 08:14:56 PDT
Comment on attachment 154065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154065&action=review > Source/WebCore/html/ColorInputType.cpp:231 > + suggestions.append(Color(option->value())); We should check Color::isValid() because HTMLOptionElement::value() might have an invalid string. Also, we shouldn't accept named color like "white".
Keishi Hattori
Comment 8 2012-07-24 19:06:45 PDT
Created attachment 154221 [details] Patch
Kent Tamura
Comment 9 2012-07-24 19:11:02 PDT
Comment on attachment 154221 [details] Patch Looks ok
WebKit Review Bot
Comment 10 2012-07-25 04:04:00 PDT
Comment on attachment 154221 [details] Patch Clearing flags on attachment: 154221 Committed r123601: <http://trac.webkit.org/changeset/123601>
WebKit Review Bot
Comment 11 2012-07-25 04:04:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.