Summary: | [EFL] Get rid of pango backend support once harfbuzz-ng is working | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||
Component: | WebKit EFL | Assignee: | Dominik Röttsches (drott) <d-r> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | antognolli+webkit, dbates, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, rwlbuis, ryuan.choi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 91853 | ||||||||
Attachments: |
|
Description
Dominik Röttsches (drott)
2012-07-24 05:36:37 PDT
If you wanna stop to support pango backend in EFL port, I think you need to notify this removal to webkit-efl as well. Created attachment 159114 [details]
Removing Pango from EFL buildsystem.
(In reply to comment #2) > Created an attachment (id=159114) [details] > Removing Pango from EFL buildsystem. Since there were no objections on webkit-efl list. Comment on attachment 159114 [details]
Removing Pango from EFL buildsystem.
This is awesome, I love code cleanups. In theory, you can also get rid of LibFindMacros.cmake, as FindPango.cmake was its last user.
As I mentioned in webkit-efl mailing list. I don't have objection for removing. However, please give me some time for webkit/tizen to catch up trunk. As I mentioned, tizen/webkit still use FontPango.cpp and FindPango.cmake And also, I heard that internal implementation of spellchecker had pango dependency. If this is not urgent task, I want to keep this until tizen/webkit solved related issues. Created attachment 159351 [details]
Removing Pango from EFL buildsystem, v2. LibFindMacros removed.
(In reply to comment #5) > As I mentioned in webkit-efl mailing list. > I don't have objection for removing. > However, please give me some time for webkit/tizen to catch up trunk. > > As I mentioned, tizen/webkit still use FontPango.cpp and FindPango.cmake > If this is not urgent task, > I want to keep this until tizen/webkit solved related issues. I think, we should clean this up in upstream quickly. You can keep a local patch for the pieces that you still need. Since there's no other dependency and it's only removing code and files, I think the maintenance overhead for keeping this as a local change is rather small. Comment on attachment 159351 [details] Removing Pango from EFL buildsystem, v2. LibFindMacros removed. Clearing flags on attachment: 159351 Committed r126010: <http://trac.webkit.org/changeset/126010> All reviewed patches have been landed. Closing bug. |