Bug 92074

Summary: Missing *explicit* keyword in dom and page
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2012-07-24 00:48:14 PDT
Some constructors missed to use *explicit* keyword. They need to be added *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion. Some files in dom directory can't use explicit keyword because of build breaks.
Attachments
Patch (32.23 KB, patch)
2012-07-24 00:50 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-24 00:50:51 PDT
Created attachment 153979 [details] Patch
Kentaro Hara
Comment 2 2012-07-24 00:59:20 PDT
Comment on attachment 153979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153979&action=review Looks OK. > Source/WebCore/ChangeLog:12 > + Some files in dom directory can't use explicit keyword because of build breaks. Some constructors are not explicit to allow type conversion intentionally. Please keep watching the tree not to break something.
Gyuyoung Kim
Comment 3 2012-07-24 01:14:54 PDT
(In reply to comment #2) > (From update of attachment 153979 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153979&action=review > > Looks OK. > > > Source/WebCore/ChangeLog:12 > > + Some files in dom directory can't use explicit keyword because of build breaks. > > Some constructors are not explicit to allow type conversion intentionally. Please keep watching the tree not to break something. Yes, I will check if there are build breaks on all ports.
Gyuyoung Kim
Comment 4 2012-07-24 02:25:43 PDT
Comment on attachment 153979 [details] Patch I'm sure GTK port also will not have build break.
WebKit Review Bot
Comment 5 2012-07-24 03:28:16 PDT
Comment on attachment 153979 [details] Patch Clearing flags on attachment: 153979 Committed r123451: <http://trac.webkit.org/changeset/123451>
WebKit Review Bot
Comment 6 2012-07-24 03:28:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.