[EFL] Use eina_stringshare_add instead of strdup.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

Eina of EFL libraries supports string functionality like strdup. So, EFL port needs to replace strdup with eina_stringshare_add. Patch is coming.

[Chris Dumez]

Yes, I was think the same. Thanks for working on this.

[Gyuyoung Kim]

Created attachment 153994 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 153994 [details]
Patch

This patch is working in progress. I need to check this patch further.

[Gyuyoung Kim]

Created attachment 154271 [details]
Patch

[Chris Dumez]

Comment on attachment 154271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154271&action=review

> Source/WebKit/efl/ChangeLog:8
> +        Eina of EFL libraries supports a string functionality like strdup. So, EFL port needs

"like eina stringsharing"

> Source/WebKit/efl/ewk/ewk_cookies.h:46
>  struct _Ewk_Cookie {

We need to document that the strings are stringshared to that the clients know they don't need to use strdup().

[Gyuyoung Kim]

Comment on attachment 154271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154271&action=review

>> Source/WebKit/efl/ChangeLog:8
>> +        Eina of EFL libraries supports a string functionality like strdup. So, EFL port needs
> 
> "like eina stringsharing"

I don't understand this comment well. Do you mean "like eina stringsharing" instead of "like strdup" ?

[Gyuyoung Kim]

Created attachment 154299 [details]
Patch

[Gyuyoung Kim]

Ok, patch is updated.

[Chris Dumez]

(In reply to comment #6)
> (From update of attachment 154271 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154271&action=review
> 
> >> Source/WebKit/efl/ChangeLog:8
> >> +        Eina of EFL libraries supports a string functionality like strdup. So, EFL port needs
> > 
> > "like eina stringsharing"
> 
> I don't understand this comment well. Do you mean "like eina stringsharing" instead of "like strdup" ?

I apparently misunderstood the sentence but I see you reformulated it in your last patch and now it is more easily understandable, thanks.

LGTM now.

[Gyuyoung Kim]

Created attachment 154324 [details]
Patch

[Kentaro Hara]

Comment on attachment 154324 [details]
Patch

Looks OK

[WebKit Review Bot]

Comment on attachment 154324 [details]
Patch

Clearing flags on attachment: 154324

Committed r123604: <http://trac.webkit.org/changeset/123604>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

This patch apparently causes webintents/web-intents-obj-constructor.html to crash on EFL port.

[Gyuyoung Kim]

(In reply to comment #14)
> This patch apparently causes webintents/web-intents-obj-constructor.html to crash on EFL port.

I'm sorry. I file a bug 92350 for this crash.