Bug 92051

Summary: run-perf-tests --build-directory doesn't work
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, kbr, ojan, rniwa, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch dpranke: review+

Stephanie Lewis
Reported 2012-07-23 18:01:00 PDT
It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build. Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs.
Attachments
Patch (2.29 KB, patch)
2012-08-01 09:35 PDT, Ryosuke Niwa 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2012-08-01 04:04:40 PDT
(In reply to comment #0) > It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build. Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs. It makes sense. On Qt-port run-perf-tests --build-directory ... doesn't work for me. Can you verify that is working for you?
Ryosuke Niwa
Comment 2 2012-08-01 09:35:50 PDT
Created attachment 155821 [details] Patch
Ryosuke Niwa
Comment 3 2012-08-01 09:36:34 PDT
This was a mind-blowingly silly bug.
Ryosuke Niwa
Comment 4 2012-08-01 10:22:14 PDT
It might make sense for --no-build to automatically turn on when --build-directory is specified. Otherwise we'll just fail after trying to build DRT.
Ryosuke Niwa
Comment 5 2012-08-01 14:03:03 PDT
Committed r124366: <http://trac.webkit.org/changeset/124366>
Note You need to log in before you can comment on or make changes to this bug.