Bug 92051

Summary: run-perf-tests --build-directory doesn't work
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, kbr, ojan, rniwa, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch dpranke: review+

Description Stephanie Lewis 2012-07-23 18:01:00 PDT 
It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build.  Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs.
Comment 1 Zoltan Horvath 2012-08-01 04:04:40 PDT 
(In reply to comment #0)
> It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build.  Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs.

It makes sense. On Qt-port run-perf-tests --build-directory ... doesn't work for me. Can you verify that is working for you?
Comment 2 Ryosuke Niwa 2012-08-01 09:35:50 PDT 
Created attachment 155821 [details]
Patch
Comment 3 Ryosuke Niwa 2012-08-01 09:36:34 PDT 
This was a mind-blowingly silly bug.
Comment 4 Ryosuke Niwa 2012-08-01 10:22:14 PDT 
It might make sense for --no-build to automatically turn on when --build-directory is specified. Otherwise we'll just fail after trying to build DRT.
Comment 5 Ryosuke Niwa 2012-08-01 14:03:03 PDT 
Committed r124366: <http://trac.webkit.org/changeset/124366>