[Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Caio Marcelo de Oliveira Filho]

The TABs are not being added in the result. I didn't investigate it deeply, but it could be a problem with out eventSender.keyDown implementation for WK2.

[Luciano Wolf]

Created attachment 163208 [details]
Fix TAB problem setting QKeyEvent keyText value

[Caio Marcelo de Oliveira Filho]

Comment on attachment 163208 [details]
Fix TAB problem setting QKeyEvent keyText value

View in context: https://bugs.webkit.org/attachment.cgi?id=163208&action=review

Nice fixing that :)

> Tools/ChangeLog:10
> +        QKeyEvent must have keyText information. Doing an experiment with QWidget
> +        and intercepting it's keyPress event it's possible to notice that TAB key
> +        returns a keyCode (Qt::Key_Tab) + a keyText ("\t").

You can omit your experiment, and add that "Regular key events generated by Qt for the tab key fill both keyCode and keyText, so we should do the same for our fake events."

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:134
> +            keyText = QString("\t");

Should we use QStringLiteral here? :-) http://woboq.com/blog/qstringliteral.html

[Luciano Wolf]

Created attachment 163217 [details]
Updated patch - after Caio's review

[WebKit Review Bot]

Comment on attachment 163217 [details]
Updated patch - after Caio's review

Clearing flags on attachment: 163217

Committed r128189: <http://trac.webkit.org/changeset/128189>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.