Bug 91969

Summary: AuthorShadowDOM for progress element
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, dominicc, eric, hayato, macpherson, menard, morrita, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82313    
Attachments:
Description Flags
Patch
none
WIP
none
Archive of layout-test-results from gce-cr-linux-02
none
WIP
none
Archive of layout-test-results from gce-cr-linux-06
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Archive of layout-test-results from apple-mac-3
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Shinya Kawanaka 2012-07-23 01:02:56 PDT
We would like to support AuthorShadowDOM for a progress element.
Comment 1 Shinya Kawanaka 2012-07-24 02:31:32 PDT
Created attachment 153996 [details]
Patch
Comment 2 Hajime Morrita 2012-07-25 19:51:17 PDT
Comment on attachment 153996 [details]
Patch

I think it's better to always have ProgressInnerElement regardless of the existence of author shadows.
Having two forms of the tree is complicated.
Also, please add a test for matching the newly introduced pseudo id.
Comment 3 Shinya Kawanaka 2012-07-25 20:13:43 PDT
It's not so clear that how do we style a progress element itself and the inner element.
Let me try it though.
Comment 4 Shinya Kawanaka 2012-07-26 01:02:23 PDT
Created attachment 154568 [details]
WIP
Comment 5 Shinya Kawanaka 2012-07-26 01:14:48 PDT
This patch needs to update several test expectations, I believe.
Comment 6 WebKit Review Bot 2012-07-26 02:21:33 PDT
Comment on attachment 154568 [details]
WIP

Attachment 154568 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13344679

New failing tests:
fast/dom/shadow/input-with-validation-without-shadow.html
fast/dom/HTMLProgressElement/progress-element-markup.html
fast/dom/HTMLProgressElement/progress-element.html
fast/dom/HTMLProgressElement/indeterminate-progress-001.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/dom/HTMLProgressElement/progress-clone.html
Comment 7 WebKit Review Bot 2012-07-26 02:21:37 PDT
Created attachment 154587 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 8 Shinya Kawanaka 2012-07-26 04:00:07 PDT
Created attachment 154605 [details]
WIP
Comment 9 WebKit Review Bot 2012-07-26 05:12:46 PDT
Comment on attachment 154605 [details]
WIP

Attachment 154605 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13345672

New failing tests:
fast/dom/shadow/shadowdom-for-progress-multiple.html
fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html
fast/dom/shadow/shadowdom-for-progress-with-style.html
Comment 10 WebKit Review Bot 2012-07-26 05:12:51 PDT
Created attachment 154616 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Build Bot 2012-07-26 19:17:27 PDT
Comment on attachment 154605 [details]
WIP

Attachment 154605 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13379079
Comment 12 Shinya Kawanaka 2012-07-31 20:27:07 PDT
Created attachment 155714 [details]
Patch
Comment 13 Build Bot 2012-07-31 20:36:36 PDT
Comment on attachment 155714 [details]
Patch

Attachment 155714 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13411248
Comment 14 Hajime Morrita 2012-07-31 20:42:11 PDT
Comment on attachment 155714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155714&action=review

> LayoutTests/platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:7
> +        RenderProgress {DIV} at (0,0) size 160x16

Is it possible to suppress this extra renderer like <img> does?
Comment 15 Shinya Kawanaka 2012-07-31 21:31:43 PDT
(In reply to comment #14)
> (From update of attachment 155714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155714&action=review
> 
> > LayoutTests/platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:7
> > +        RenderProgress {DIV} at (0,0) size 160x16
> 
> Is it possible to suppress this extra renderer like <img> does?

Let me try
Comment 16 Shinya Kawanaka 2012-08-01 04:02:56 PDT
Created attachment 155776 [details]
Patch
Comment 17 Shinya Kawanaka 2012-08-01 20:43:37 PDT
Created attachment 155960 [details]
Patch
Comment 18 Build Bot 2012-08-01 20:55:53 PDT
Comment on attachment 155960 [details]
Patch

Attachment 155960 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13403844
Comment 19 Shinya Kawanaka 2012-08-01 21:33:40 PDT
Created attachment 155969 [details]
Patch
Comment 20 Hajime Morrita 2012-08-02 20:11:10 PDT
Comment on attachment 155969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155969&action=review

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:607
> +

Please remove unnecessary change.

> Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:-612
> -

Ditto.
Comment 21 Shinya Kawanaka 2012-08-02 23:52:41 PDT
Created attachment 156268 [details]
Patch for landing
Comment 22 Build Bot 2012-08-03 02:10:30 PDT
Comment on attachment 156268 [details]
Patch for landing

Attachment 156268 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13423728

New failing tests:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/dom/HTMLProgressElement/progress-writing-mode.html
fast/dom/HTMLProgressElement/indeterminate-progress-001.html
Comment 23 Build Bot 2012-08-03 02:10:34 PDT
Created attachment 156295 [details]
Archive of layout-test-results from apple-mac-3

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: apple-mac-3  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.7.4
Comment 24 Shinya Kawanaka 2012-08-03 03:42:46 PDT
Created attachment 156311 [details]
Patch for landing
Comment 25 Shinya Kawanaka 2012-08-05 23:14:18 PDT
Created attachment 156601 [details]
Patch for landing
Comment 26 WebKit Review Bot 2012-08-06 03:03:53 PDT
Comment on attachment 156601 [details]
Patch for landing

Rejecting attachment 156601 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rce/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 1 files

Full output: http://queues.webkit.org/results/13435756
Comment 27 Shinya Kawanaka 2012-08-06 03:25:20 PDT
Created attachment 156645 [details]
Patch for landing
Comment 28 WebKit Review Bot 2012-08-06 05:00:30 PDT
Comment on attachment 156645 [details]
Patch for landing

Clearing flags on attachment: 156645

Committed r124754: <http://trac.webkit.org/changeset/124754>
Comment 29 WebKit Review Bot 2012-08-06 05:00:47 PDT
All reviewed patches have been landed.  Closing bug.