Bug 91963 – Null-pointer crash when parsing border-image

• Component: CSS
• Status: RESOLVED FIXED

Null-pointer crash when parsing border-image

Created attachment 153741 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 153741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review

> LayoutTests/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

The changelog is wrong here.

> LayoutTests/fast/css/border-image-fill-crash.html:7
> +    testRunner.dumpAsText();

You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

Created attachment 153891 [details]
Patch

(In reply to comment #2)
> (From update of attachment 153741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> The changelog is wrong here.

OOPS! Fixed.
 
> > LayoutTests/fast/css/border-image-fill-crash.html:7
> > +    testRunner.dumpAsText();
> 
> You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

I can see how this might be helpful for a JavaScript based test, but in this case I think it would just make the test harder to read, what do you think?

[WebKit Review Bot]

Comment on attachment 153891 [details]
Patch

Clearing flags on attachment: 153891

Committed r123406: <http://trac.webkit.org/changeset/123406>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.