Bug 91962

Summary: Improve AudioChannelSplitter test
Product: WebKit Reporter: Li Yin <li.yin>
Component: Web AudioAssignee: Li Yin <li.yin>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, eric.carlson, feature-media-reviews, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94540    
Attachments:
Description Flags
Patch none

Li Yin
Reported 2012-07-22 23:35:53 PDT
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section The numberOfOutputs parameter determines the number of outputs. Values of up to 32 must be supported. If not specified, then 6 will be used. The test should cover empty parmeter and some values needed to be supported.
Attachments
Patch (3.79 KB, patch)
2012-07-22 23:43 PDT, Li Yin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Li Yin
Comment 1 2012-07-22 23:43:37 PDT
Created attachment 153738 [details] Patch
Kentaro Hara
Comment 2 2012-07-22 23:54:22 PDT
Comment on attachment 153738 [details] Patch Looks OK. Shall we add more test cases for "An exception will be thrown for invalid parameter values" in a follow-up patch? (e.g. null, undefined, "123" etc)
Li Yin
Comment 3 2012-07-23 00:30:08 PDT
(In reply to comment #2) > (From update of attachment 153738 [details]) > Looks OK. Shall we add more test cases for "An exception will be thrown for invalid parameter values" in a follow-up patch? (e.g. null, undefined, "123" etc) Thanks for your review. These invalid parameter should be general for all the test. They should be depended on JS or V8 core. I think other tests have covered them already. I wander if it is necessary to cover these details.
WebKit Review Bot
Comment 4 2012-07-23 00:53:39 PDT
Comment on attachment 153738 [details] Patch Clearing flags on attachment: 153738 Committed r123309: <http://trac.webkit.org/changeset/123309>
WebKit Review Bot
Comment 5 2012-07-23 00:53:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.