Summary: | [EFL] Change prototype of run_open_panel | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kihong Kwon <kihong.kwon> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, haraken, lucas.de.marchi, rakuco, sw0524.lee, vimff0, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 91957 | ||||||||
Bug Blocks: | 91842 | ||||||||
Attachments: |
|
Description
Kihong Kwon
2012-07-22 21:15:12 PDT
Created attachment 154315 [details]
Patch
Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review > Source/WebKit/efl/ChangeLog:10 > + i.e., change "Eina_Bool allows_multiple_files, Eina_List *accpet_types" Nit: s/accpet/accept/ > Source/WebKit/efl/ewk/ewk_view.h:191 > - Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Eina_Bool allows_multiple_files, Eina_List *accept_types, Eina_List **selected_filenames); > + Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser *file_chooser, Eina_List **selected_filenames); Whenever you change this public smart class you must update EWK_VIEW_SMART_CLASS_VERSION below. Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review > Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:487 > filenames.append((char*)filename); I know this is not related to your patch but since you're touching this part of the code: We should probably use here: filenames.append(String::fromUTF8(static_cast<char*>(filename))); Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review >> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:487 >> filenames.append((char*)filename); > > I know this is not related to your patch but since you're touching this part of the code: > We should probably use here: filenames.append(String::fromUTF8(static_cast<char*>(filename))); OK, I will do that. >> Source/WebKit/efl/ewk/ewk_view.h:191 >> + Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser *file_chooser, Eina_List **selected_filenames); > > Whenever you change this public smart class you must update EWK_VIEW_SMART_CLASS_VERSION below. Done. Created attachment 154816 [details]
Patch
Comment on attachment 154816 [details]
Patch
Looks fine.
Comment on attachment 154816 [details]
Patch
rs=me
Comment on attachment 154816 [details] Patch Clearing flags on attachment: 154816 Committed r123847: <http://trac.webkit.org/changeset/123847> All reviewed patches have been landed. Closing bug. |