Bug 91948 – Move GregorianDateTime from JSC to WTF namespace

• Component: New Bugs
• Status: RESOLVED FIXED

[Patrick R. Gansterer]

Move GregorianDateTime from JSC to WTF namespace

[Patrick R. Gansterer]

Created attachment 153707 [details]
Patch

[WebKit Review Bot]

Attachment 153707 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 153707 [details]
Patch

Attachment 153707 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13310877

[Early Warning System Bot]

Comment on attachment 153707 [details]
Patch

Attachment 153707 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13318735

[Patrick R. Gansterer]

Created attachment 153709 [details]
Patch

[WebKit Review Bot]

Attachment 153709 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 153709 [details]
Patch

Attachment 153709 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13308916

[Patrick R. Gansterer]

Created attachment 153737 [details]
Patch

[WebKit Review Bot]

Attachment 153737 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 153737 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 153737 [details]
Patch

Rejecting attachment 153737 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ist.am
patching file Source/WTF/WTF.gypi
patching file Source/WTF/WTF.pro
patching file Source/WTF/WTF.xcodeproj/project.pbxproj
patching file Source/WTF/wtf/CMakeLists.txt
patching file Source/WTF/wtf/GregorianDateTime.h
patching file Source/WebCore/bridge/qt/qt_runtime.cpp
patching file Source/WebCore/bridge/qt/qt_runtime_qt4.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Geoffrey G..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13332164

[Patrick R. Gansterer]

Committed r123425: <http://trac.webkit.org/changeset/123425>