Summary: | [JSC] REGRESSION(r122912): CodeGeneratorJS.pm should not implicitly assume ScriptExecutionContext for static attributes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, japhet, jochen, jonlee, oliver, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 91764 | ||||||||
Bug Blocks: | 88919, 92413 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-07-21 03:18:43 PDT
Created attachment 153942 [details]
Patch
Comment on attachment 153942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153942&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-1887 > } > - } Indentation is wrong here. Let me fix it in a follow-up patch (because the indentation fix will mess up this patch). > Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:248 > + JSValue result = jsNumber(TestSupplemental::supplementalStaticReadOnlyAttr(impl)); Passing 'impl' is wrong. This will be fixed in bug 91925. Thanks for keeping the diff clean. rs=me to fix the indent. Created attachment 153967 [details]
fix indentation, patch for landing
Comment on attachment 153967 [details] fix indentation, patch for landing Clearing flags on attachment: 153967 Committed r123433: <http://trac.webkit.org/changeset/123433> This patch does not appropriately call the static attribute function with ScriptExecutionContext if [CallWith=ScriptExecutionContext] is specified. (In reply to comment #6) > This patch does not appropriately call the static attribute function with ScriptExecutionContext if [CallWith=ScriptExecutionContext] is specified. Sorry I misspoke, I put the attribute in the wrong place. |