Bug 91917

Summary: [chromium] Add more compositor unit tests for high DPI transforms
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: danakj, enne, jamesr, kbr, senorblanco, shawnsingh, vollick, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91417    
Attachments:
Description Flags
Patch
none
Patch
none
Fix egregious typo
none
More tests; fix scale for duplicateChild test
none
Rebased to ToT
none
Reorder expect calls none

Adrienne Walker
Reported 2012-07-20 21:32:49 PDT
[chromium] Add more compositor unit tests for high DPI transforms
Attachments
Patch (8.87 KB, patch)
2012-07-20 21:34 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Patch (10.64 KB, patch)
2012-07-20 22:07 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Fix egregious typo (10.75 KB, patch)
2012-07-20 23:53 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
More tests; fix scale for duplicateChild test (12.00 KB, patch)
2012-07-21 18:36 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Rebased to ToT (11.94 KB, patch)
2012-07-23 17:22 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Reorder expect calls (11.94 KB, patch)
2012-07-23 17:29 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-07-20 21:34:03 PDT
Created attachment 153645 [details] Patch
Adrienne Walker
Comment 2 2012-07-20 22:07:41 PDT
Created attachment 153646 [details] Patch
Adrienne Walker
Comment 3 2012-07-20 23:53:16 PDT
Created attachment 153655 [details] Fix egregious typo
Adrienne Walker
Comment 4 2012-07-21 18:36:23 PDT
Created attachment 153681 [details] More tests; fix scale for duplicateChild test
Adrienne Walker
Comment 5 2012-07-21 18:37:17 PDT
Sorry for all the patch noise. The previous patches had a bug in them that caused problems in dependent patches. This is ready for review.
Dana Jansens
Comment 6 2012-07-23 14:04:53 PDT
Comment on attachment 153681 [details] More tests; fix scale for duplicateChild test View in context: https://bugs.webkit.org/attachment.cgi?id=153681&action=review nice tests! lgtm > Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:3722 > + EXPECT_TRANSFORMATION_MATRIX_EQ(parent->screenSpaceTransform(), expectedParentScreenSpaceTransform); nit: expected value should come first in all these
vollick
Comment 7 2012-07-23 14:08:50 PDT
Comment on attachment 153681 [details] More tests; fix scale for duplicateChild test Nice! LGTM, too.
Shawn Singh
Comment 8 2012-07-23 14:11:19 PDT
Seems great to me too, but I did have one question - do you think we need to be testing more explicitly something about order of operations, just in case? it looks like we are implicitly testing order of operations between the scale and the layer position translation, but do we need to also check how the contents scale is ordered with respect to the compositeLayerTransform and compositeSublayerTransform? I'm OK with the patch as-is, just wanted to throw that idea out there in case someone felt strongly.
Adrienne Walker
Comment 9 2012-07-23 17:22:43 PDT
Created attachment 153911 [details] Rebased to ToT
Adrienne Walker
Comment 10 2012-07-23 17:29:17 PDT
Created attachment 153913 [details] Reorder expect calls
Dana Jansens
Comment 11 2012-07-23 17:30:52 PDT
Thanks for that. @kbr or @senorblanco for review?
Adrienne Walker
Comment 12 2012-07-23 17:32:30 PDT
The diff from two patches ago is just to remove the clip rect line to rebase, one typo fix, and to reorder expect calls as Dana asked.
Kenneth Russell
Comment 13 2012-07-23 17:47:13 PDT
Comment on attachment 153913 [details] Reorder expect calls rs=me based on Dana's review.
WebKit Review Bot
Comment 14 2012-07-23 17:57:38 PDT
Comment on attachment 153913 [details] Reorder expect calls Clearing flags on attachment: 153913 Committed r123413: <http://trac.webkit.org/changeset/123413>
WebKit Review Bot
Comment 15 2012-07-23 17:57:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.