Bug 91865

Summary: [chromium] Enable the GPU-accelerated skia path for SVG lighting filters
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, kbr, krit, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Stephen White
Reported 2012-07-20 08:09:58 PDT
[chromium] Enable the GPU-accelerated skia path for SVG lighting filters
Attachments
Patch (7.89 KB, patch)
2012-07-20 08:38 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.87 KB, patch)
2012-07-20 09:24 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2012-07-20 08:38:01 PDT
Created attachment 153511 [details] Patch
Dirk Schulze
Comment 2 2012-07-20 08:51:07 PDT
Comment on attachment 153511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153511&action=review LGTM. r=me. > Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp:90 > + if (!limitingConeAngle || limitingConeAngle > 90.0f || limitingConeAngle < -90.0f) Omit the .0f every please. This is against style rules.
Stephen White
Comment 3 2012-07-20 09:24:56 PDT
Created attachment 153522 [details] Patch for landing
Stephen White
Comment 4 2012-07-20 09:26:06 PDT
(In reply to comment #2) > (From update of attachment 153511 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153511&action=review > > LGTM. r=me. Thanks for the review. > > Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp:90 > > + if (!limitingConeAngle || limitingConeAngle > 90.0f || limitingConeAngle < -90.0f) > > Omit the .0f every please. This is against style rules. Done in patch for landing.
WebKit Review Bot
Comment 5 2012-07-20 10:14:14 PDT
Comment on attachment 153522 [details] Patch for landing Clearing flags on attachment: 153522 Committed r123225: <http://trac.webkit.org/changeset/123225>
WebKit Review Bot
Comment 6 2012-07-20 10:14:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.