Bug 91862 – Update text upon item selection for menu lists

• Component: Forms
• Status: ASSIGNED

[Pierre Rossi]

Update text upon item selection for menu lists

[Alexey Proskuryakov]

Can you please provide more information, e.g. a test case?

[Pierre Rossi]

Created attachment 154012 [details]
Patch

[Pierre Rossi]

Comment on attachment 154012 [details]
Patch

@ap: I got somewhat sidetracked trying to look if that could be covered by a layout test. Here's the patch I had in mind, just to make the bug less cryptic for now.

[Eric Seidel (no email)]

Comment on attachment 154012 [details]
Patch

I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process.

[Benjamin Poulain]

Comment on attachment 154012 [details]
Patch

(In reply to comment #4)
> (From update of attachment 154012 [details])
> I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process.

Agreed. Any reason why is setTextFromItem() not called from listBoxSelectItem?

+ How do we test this?

[Pierre Rossi]

Created attachment 183995 [details]
Patch

[Pierre Rossi]

@Benjamin: Too hackish ? ;)(In reply to comment #5)
> (From update of attachment 154012 [details])
> (In reply to comment #4)
> > (From update of attachment 154012 [details] [details])
> > I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process.
> 
> Agreed. Any reason why is setTextFromItem() not called from listBoxSelectItem?
> 
Couldn't be bothered to expose one more function publicly I guess...

> + How do we test this?
What do you think ? Too hackish ?

[kov's GTK+ EWS bot]

Comment on attachment 183995 [details]
Patch

Attachment 183995 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16035676

[Build Bot]

Comment on attachment 183995 [details]
Patch

Attachment 183995 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16031696

[WebKit Review Bot]

Comment on attachment 183995 [details]
Patch

Attachment 183995 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16045658

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
fast/forms/select/option-selecting.html
fast/dom/HTMLSelectElement/selected-false.html

[Build Bot]

Comment on attachment 183995 [details]
Patch

Attachment 183995 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16035692

[Build Bot]

Comment on attachment 183995 [details]
Patch

Attachment 183995 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16031831

[Pierre Rossi]

Created attachment 184464 [details]
Patch

[Build Bot]

Comment on attachment 184464 [details]
Patch

Attachment 184464 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16080653

[Build Bot]

Comment on attachment 184464 [details]
Patch

Attachment 184464 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16110057

[Pierre Rossi]

Created attachment 184492 [details]
Patch

[Build Bot]

Comment on attachment 184492 [details]
Patch

Attachment 184492 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16119065

[Build Bot]

Comment on attachment 184492 [details]
Patch

Attachment 184492 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16123067

[Build Bot]

Comment on attachment 184492 [details]
Patch

Attachment 184492 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16124124

[WebKit Review Bot]

Comment on attachment 184492 [details]
Patch

Attachment 184492 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16117233

New failing tests:
svg/W3C-SVG-1.1/types-basicDOM-01-b.svg

[Pierre Rossi]

Created attachment 194573 [details]
Patch

[Pierre Rossi]

Attempt to make the gtk and win EWS smile again.

[Pierre Rossi]

Created attachment 194651 [details]
Patch

[Build Bot]

Comment on attachment 194651 [details]
Patch

Attachment 194651 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17239475

[Pierre Rossi]

Created attachment 194697 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194697 [details]
Patch

Attachment 194697 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17250296

New failing tests:
fast/forms/select/optgroup-rendering.html
fast/forms/select/option-selecting.html
fast/forms/select/menulist-multiple-text-update.html
fast/forms/select/optgroup-clicking.html

[WebKit Review Bot]

Created attachment 194713 [details]
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Pierre Rossi]

Created attachment 195034 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195034 [details]
Patch

Attachment 195034 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17337028

New failing tests:
fast/forms/select/menulist-multiple-text-update.html

[WebKit Review Bot]

Created attachment 195046 [details]
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[WebKit Review Bot]

Comment on attachment 195034 [details]
Patch

Attachment 195034 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17246522

New failing tests:
fast/forms/select/menulist-multiple-text-update.html

[WebKit Review Bot]

Created attachment 195054 [details]
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Pierre Rossi]

*** Bug 113045 has been marked as a duplicate of this bug. ***

[Pierre Rossi]

Created attachment 195260 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17309388

[Peter Beverloo (cr-android ews)]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17314348

[WebKit Review Bot]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17314354

[EFL EWS Bot]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17330188

[Build Bot]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17314362

[Build Bot]

Comment on attachment 195260 [details]
Patch

Attachment 195260 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17299226

[Pierre Rossi]

Created attachment 195312 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195312 [details]
Patch

Attachment 195312 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17336129

New failing tests:
fast/forms/select/menulist-multiple-text-update.html

[WebKit Review Bot]

Created attachment 195327 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Pierre Rossi]

Created attachment 195424 [details]
Patch

[Nick Monkman]

I'm seeing this behavior in Qt 5.3.0 on Linux and it is causing major headaches for my project.

Any updates on this? Is the patch still awaiting review? I'm brand new to WebKit but I'm willing to help out however I can...

Nick

[Brady Eidson]

Comment on attachment 195424 [details]
Patch

r- to clear stale patches from the review queue