Bug 91826

Summary: ComposedShadowTreeWalker should skip an empty insertion points.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91825    
Attachments:
Description Flags
Skip empty insertion points and continue walking
none
Patch for landing none

Hayato Ito
Reported 2012-07-20 00:17:36 PDT
When a last child node is an insertion point which does not have distributed nodes nor fallback elements, ComposedShadowTreeWalker::lastChild should ignore such a insertion point. Currently, walker.get() wrongly returns null after walker.lastChild() is called in such case.
Attachments
Skip empty insertion points and continue walking (12.02 KB, patch)
2012-07-22 23:48 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.01 KB, patch)
2012-07-23 00:20 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-07-22 23:48:34 PDT
Created attachment 153739 [details] Skip empty insertion points and continue walking
Hayato Ito
Comment 2 2012-07-23 00:20:38 PDT
Created attachment 153742 [details] Patch for landing
WebKit Review Bot
Comment 3 2012-07-23 01:08:56 PDT
Comment on attachment 153742 [details] Patch for landing Clearing flags on attachment: 153742 Committed r123312: <http://trac.webkit.org/changeset/123312>
WebKit Review Bot
Comment 4 2012-07-23 01:08:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.