Bug 91826 - ComposedShadowTreeWalker should skip an empty insertion points.
Summary: ComposedShadowTreeWalker should skip an empty insertion points.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 91825
  Show dependency treegraph
 
Reported: 2012-07-20 00:17 PDT by Hayato Ito
Modified: 2012-07-23 01:08 PDT (History)
6 users (show)

See Also:


Attachments
Skip empty insertion points and continue walking (12.02 KB, patch)
2012-07-22 23:48 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
Patch for landing (12.01 KB, patch)
2012-07-23 00:20 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-07-20 00:17:36 PDT
When a last child node is an insertion point which does not have distributed nodes nor fallback elements, ComposedShadowTreeWalker::lastChild should ignore such a insertion point.
Currently, walker.get() wrongly returns null after walker.lastChild() is called in such case.
Comment 1 Hayato Ito 2012-07-22 23:48:34 PDT
Created attachment 153739 [details]
Skip empty insertion points and continue walking
Comment 2 Hayato Ito 2012-07-23 00:20:38 PDT
Created attachment 153742 [details]
Patch for landing
Comment 3 WebKit Review Bot 2012-07-23 01:08:56 PDT
Comment on attachment 153742 [details]
Patch for landing

Clearing flags on attachment: 153742

Committed r123312: <http://trac.webkit.org/changeset/123312>
Comment 4 WebKit Review Bot 2012-07-23 01:08:59 PDT
All reviewed patches have been landed.  Closing bug.