Summary: | create SourceBuffer and SourceBufferList objects | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anna Cavender <annacc> | ||||||||||
Component: | Media | Assignee: | Anna Cavender <annacc> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, acolwell, eric.carlson, feature-media-reviews, gyuyoung.kim, ojan, rakuco, vestbo, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 90819 | ||||||||||||
Attachments: |
|
Description
Anna Cavender
2012-07-19 12:38:59 PDT
Created attachment 153333 [details]
Patch
Comment on attachment 153333 [details] Patch Attachment 153333 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13301083 Created attachment 153564 [details]
fix windows build files
Created attachment 153898 [details]
no diff, hoping win bot will run this time
Comment on attachment 153898 [details] no diff, hoping win bot will run this time View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59 > + UNUSED_PARAM(data); > + // FIXME(91773): append the data to the media source. Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter. Comment on attachment 153898 [details] no diff, hoping win bot will run this time Thanks, Eric! View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59 >> + // FIXME(91773): append the data to the media source. > > Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter. Gone. Created attachment 154098 [details]
Patch for landing
Comment on attachment 154098 [details] Patch for landing Clearing flags on attachment: 154098 Committed r123522: <http://trac.webkit.org/changeset/123522> All reviewed patches have been landed. Closing bug. |