Web Inspector: minimize number of properties on WebInspector.TimelinePresentationModel.Record

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Kosyakov]

We create an instance of WebInspector.TimelinePresentationModel.Record for each timeline record. Most of the formatted record's fields so far are just copies of those on the low-level record. This change replaces those with getters, which reduces amount of space these records occupy nearly twice (11.7M => 6.77M for records, 9.3M => 7.3M for numbers).

[Andrey Kosyakov]

Created attachment 153263 [details]
Patch

[Pavel Feldman]

Comment on attachment 153263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153263&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:391
> +    this._style = WebInspector.TimelinePresentationModel.recordStyle(record);

This could be done lazily.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:517
> +    get category()

Please annotate new members.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519
> +        return this._style.category

Inline _style here.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:524
> +        return this.type === WebInspector.TimelineModel.RecordType.TimeStamp ? this._record.data["message"] : this._style.title;

Inline _style here.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:562
> +    get _selfTime()

We never do private getters.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:571
> +    },

return null;

[Andrey Kosyakov]

Committed r123108: <http://trac.webkit.org/changeset/123108>