Bug 91711

Summary:

[EFL] Enable interactive form validation

Product:

WebKit

Reporter:

Kihong Kwon <kihong.kwon>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Kihong Kwon

Reported 2012-07-18 22:24:56 PDT

Enable interactive form validation in the WebCore::Settings. It is already enabled at gtk, blackberry, chromium and mac ports, and EFL also already enables it in the DRT. This makes we can validate data at form elements. In addition, if we disable this in the DRT, we have 14 regressions about form validation. -------------------------------------------------------------------------------- Unexpected flakiness: text diff mismatch (1) fast/forms/interactive-validation-attach-assertion.html = TEXT TIMEOUT PASS Unexpected flakiness: tests timed out (1) fast/forms/validation-message-clone.html = TEXT TIMEOUT PASS Regressions: Unexpected text diff mismatch : (12) fast/forms/interactive-validation-assertion-by-validate-twice.html = TEXT fast/forms/interactive-validation-crash-by-style-override.html = TEXT fast/forms/interactive-validation-prevented.html = TEXT fast/forms/interactive-validation-select-crash.html = TEXT fast/forms/validation-message-appearance.html = TEXT fast/forms/validation-message-in-relative-body.html = TEXT fast/forms/validation-message-on-checkbox.html = TEXT fast/forms/validation-message-on-listbox.html = TEXT fast/forms/validation-message-on-menulist.html = TEXT fast/forms/validation-message-on-radio.html = TEXT fast/forms/validation-message-on-range.html = TEXT fast/forms/validation-message-on-textarea.html = TEXT

Attachments
Patch (1.45 KB, patch) 2012-07-18 22:30 PDT, Kihong Kwon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kihong Kwon

Comment 1 2012-07-18 22:30:29 PDT

Created attachment 153179 [details] Patch

Gyuyoung Kim

Comment 2 2012-07-18 22:36:16 PDT

Comment on attachment 153179 [details] Patch Looks fine. BTW, can we adjust this setting int EFL WK2 as well ?

Kihong Kwon

Comment 3 2012-07-18 22:38:42 PDT

(In reply to comment #2) > (From update of attachment 153179 [details]) > Looks fine. BTW, can we adjust this setting int EFL WK2 as well ? OK, I will do that. Thanks.

Gyuyoung Kim

Comment 4 2012-07-18 23:26:14 PDT

Oops, I forgot an initial patch for page setting of WK2 EFL is being reviewed on Bug 91206. So, I think this patch can be landed first. Please file a new bug after landing Bug 91206.

WebKit Review Bot

Comment 5 2012-07-19 00:11:20 PDT

Comment on attachment 153179 [details] Patch Clearing flags on attachment: 153179 Committed r123075: <http://trac.webkit.org/changeset/123075>

WebKit Review Bot

Comment 6 2012-07-19 00:11:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.